New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829085 link

Starred by 1 user
Status: Fixed
Owner:
valleau@chromium.org
Closed: Apr 2018
Cc:
█ snambiar@chromium.org
skau@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Change CupsPrintersHandler to Prevent Configuration when Enterprise Policy is Set

Project Member Reported by valleau@chromium.org, Apr 4 2018 
Although the UI is meant to prevent users from configuring native printers when the policy pref "UserNativePrintersAllowed" is set to false, it is still technically possible for the user to get around this and add printers anyways by modifying the JavaScript.

For the sake of completeness, we should perform a check on the policy value in CupsPrintersHandler and prevent any configuration of native printers if it is set.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72c015e177d264f5b063f7d90444a3d51e2570e

commit d72c015e177d264f5b063f7d90444a3d51e2570e
Author: David Valleau <valleau@chromium.org>
Date: Tue Apr 24 21:38:30 2018

Changing CupsPrintersHandler to use the enterprise printer policy

BUG= chromium:829085 
TEST=Tested manually on device

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9353962f50ba3ea78abe8251e4ec3c2f140cb432
Reviewed-on: https://chromium-review.googlesource.com/1008967
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553291}
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/browser/chromeos/printing/printer_configurer.h
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/browser/resources/settings/printing_page/cups_printers.js
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/d72c015e177d264f5b063f7d90444a3d51e2570e/tools/metrics/histograms/enums.xml

Comment 2 by valleau@chromium.org, Apr 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment