Tracking bug for Layered Web API infrastructure in Chromium. https://bit.ly/layered-web-apis-design
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f3e01344a88d5f7b922de2793cdbac3144df95b commit 4f3e01344a88d5f7b922de2793cdbac3144df95b Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Apr 27 18:21:57 2018 Do not use ModuleScriptFetchRequest for Modulator::FetchTree() Layered API [1] is planning to insert a step that modifies |url| to #fetch-a-module-script-tree, and thus the URLs for #fetch-a-module-script-tree and #internal-module-script-graph-fetching-procedure can be different. However, ModuleScriptFetchRequest::Url() has been used for both of them and thus the same URL is used for both. This CL stops using ModuleScriptFetchRequest for #fetch-a-module-script-tree (i.e. ModuleTreeLinker::FetchRoot() and its callers) and instead pass URL and ScriptFetchOptions separately, in order to modify the URL inside ModuleTreeLinker::FetchRoot() in a following CL [2]. [1] https://github.com/drufball/layered-apis/blob/master/spec.md [2] https://chromium-review.googlesource.com/1013321 This CL also introduced ModuleScriptFetchRequest::CreateForTest(), and make non-test users call the full (previously private) constructor of ModuleScriptFetchRequest. Bug: 829084 Change-Id: I17d34475f0a85a5a1b7212d9bc8530d838e75f20 Reviewed-on: https://chromium-review.googlesource.com/1013317 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#554425} [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/link_loader.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_script_fetch_request.h [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/dynamic_module_resolver.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/modulator.h [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/modulator_impl_base.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/modulator_impl_base.h [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/module_map_test.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/script/script_loader.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/testing/dummy_modulator.cc [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/testing/dummy_modulator.h [modify] https://crrev.com/4f3e01344a88d5f7b922de2793cdbac3144df95b/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99d5821e952e2c6b025e4e80443a9b078630a7f7 commit 99d5821e952e2c6b025e4e80443a9b078630a7f7 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Wed May 02 04:25:41 2018 [Layered API] Add runtime flags for Layered APIs This CL adds "enable-layered-api" flag to chrome://flags and a corresponding web runtime feature that will enable Layered API. Also, this CL enables Layered API when ExperimentalProductivityFeatures is enabled. Bug: 829084 Change-Id: I0ed0346aa9bc685b2ba79ce5ba353a6f7f614c40 Reviewed-on: https://chromium-review.googlesource.com/1013319 Reviewed-by: Ojan Vafai <ojan@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#555310} [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/chrome/browser/about_flags.cc [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/chrome/browser/flag_descriptions.h [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/content/child/runtime_features.cc [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/content/public/common/content_features.cc [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/content/public/common/content_features.h [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/third_party/blink/public/platform/web_runtime_features.h [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/third_party/blink/renderer/platform/exported/web_runtime_features.cc [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/third_party/blink/renderer/platform/runtime_enabled_features.json5 [modify] https://crrev.com/99d5821e952e2c6b025e4e80443a9b078630a7f7/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/1037c743e33821d9aebda2624be4cc2a9a35c21d commit 1037c743e33821d9aebda2624be4cc2a9a35c21d Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed May 02 16:33:27 2018 presubmit: Don't overwrite cwd when running tests. Sometimes 'cwd' has already been specified, for example by GetPythonUnitTests. Don't overwrite it if it has been. TBR=agable@chromium.org Bug: 829084 Change-Id: Ide65c2811bcdd2628d4e886227d634dc66bfd297 Reviewed-on: https://chromium-review.googlesource.com/1038665 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/1037c743e33821d9aebda2624be4cc2a9a35c21d/presubmit_support.py [modify] https://crrev.com/1037c743e33821d9aebda2624be4cc2a9a35c21d/tests/presubmit_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18067abe5db7cf0e25730f143ed6511d444a1634 commit 18067abe5db7cf0e25730f143ed6511d444a1634 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 02 18:35:53 2018 Roll src/third_party/depot_tools/ 1eb58e1f8..1037c743e (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1eb58e1f8892..1037c743e338 $ git log 1eb58e1f8..1037c743e --date=short --no-merges --format='%ad %ae %s' 2018-05-01 ehmaldonado presubmit: Don't overwrite cwd when running tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:829084 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iba54fff4eeb01ec9698dab0338cb391054c1874a Reviewed-on: https://chromium-review.googlesource.com/1040106 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555483} [modify] https://crrev.com/18067abe5db7cf0e25730f143ed6511d444a1634/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bde742c2e4758ae132847b0434d516dc91892d7d commit bde742c2e4758ae132847b0434d516dc91892d7d Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Wed May 02 21:07:17 2018 [Layered API] Implement Layered API infrastructure behind a flag This CL 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), 2. Then maps to std-internal://x/index.js (not spec'ed [2]) in GetInternalURL(), 3. Then retrieves and serves the script contents for std-internal: URLs in GetSourceText() using ui::ResourceBundle() from blink_resources.pak. The source JavaScript files for Layered APIs are placed under third_party/blink/renderer/core/script/resources/layered_api and bundled into blink_resources.pak. This CL introduces std: and std-internal: schemes that are used in Blink side (std: is user-facing while std-internal: is mostly invisible for users) but not outside Blink. [1] Spec: https://github.com/drufball/layered-apis/blob/master/spec.md [2] Implementation design doc: https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit Bug: 829084 Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 Reviewed-on: https://chromium-review.googlesource.com/1013321 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#555524} [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/public/blink_resources.grd [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/script/BUILD.gn [add] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/script/layered_api.cc [add] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/script/layered_api.h [add] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/script/layered_api_test.cc [modify] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/script/modulator.cc [add] https://crrev.com/bde742c2e4758ae132847b0434d516dc91892d7d/third_party/blink/renderer/core/script/resources/layered_api/blank/index.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1444365c805a462f54ccdd1e97810349e898f297 commit 1444365c805a462f54ccdd1e97810349e898f297 Author: Marc Treib <treib@chromium.org> Date: Thu May 03 11:50:14 2018 Revert "[Layered API] Implement Layered API infrastructure behind a flag" This reverts commit bde742c2e4758ae132847b0434d516dc91892d7d. Reason for revert: LayeredAPITest.GetSourceText is failing on Android CFI and WebKit Android (Nexus4): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/?limit=100 https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/ Original change's description: > [Layered API] Implement Layered API infrastructure behind a flag > > This CL > 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), > 2. Then maps to std-internal://x/index.js (not spec'ed [2]) > in GetInternalURL(), > 3. Then retrieves and serves the script contents for std-internal: > URLs in GetSourceText() using ui::ResourceBundle() > from blink_resources.pak. > > The source JavaScript files for Layered APIs are placed under > third_party/blink/renderer/core/script/resources/layered_api > and bundled into blink_resources.pak. > > This CL introduces std: and std-internal: schemes that are used in Blink side > (std: is user-facing while std-internal: is mostly invisible for users) > but not outside Blink. > > [1] Spec: > https://github.com/drufball/layered-apis/blob/master/spec.md > [2] Implementation design doc: > https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit > > Bug: 829084 > Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 > Reviewed-on: https://chromium-review.googlesource.com/1013321 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555524} TBR=kinuko@chromium.org,thakis@chromium.org,hiroshige@chromium.org,kouhei@chromium.org Change-Id: I6e13216a99d4ed199f9a52d370f3cad35900f408 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829084 Reviewed-on: https://chromium-review.googlesource.com/1042065 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#555695} [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/public/blink_resources.grd [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/script/BUILD.gn [delete] https://crrev.com/656d3dcac67b87a3fc062e0d9801644683530c4b/third_party/blink/renderer/core/script/layered_api.cc [delete] https://crrev.com/656d3dcac67b87a3fc062e0d9801644683530c4b/third_party/blink/renderer/core/script/layered_api.h [delete] https://crrev.com/656d3dcac67b87a3fc062e0d9801644683530c4b/third_party/blink/renderer/core/script/layered_api_test.cc [modify] https://crrev.com/1444365c805a462f54ccdd1e97810349e898f297/third_party/blink/renderer/core/script/modulator.cc [delete] https://crrev.com/656d3dcac67b87a3fc062e0d9801644683530c4b/third_party/blink/renderer/core/script/resources/layered_api/blank/index.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92165b0af7b2a8287a71eee5deef3fc3c2894feb commit 92165b0af7b2a8287a71eee5deef3fc3c2894feb Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri May 04 00:59:53 2018 Add skip_minify option to grit tool As the current minifier doesn't support module scripts (e.g. import statements) and [1] is going to add module scripts that contain imports to a grit archive, this CL adds a |skip_minify| option to skip minifier for individual files as a workaround. |skip_minify| will be used in [1]. [1] https://chromium-review.googlesource.com/1031749 Bug: 829084, 839512 Change-Id: Ie4c3ad21cd2ef8cfb715d0eb57e7045f754acc1a Reviewed-on: https://chromium-review.googlesource.com/1031108 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555940} [modify] https://crrev.com/92165b0af7b2a8287a71eee5deef3fc3c2894feb/tools/grit/grit/node/include.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cade90a3e92dd3727ac95afb0dde2eadecc29ee7 commit cade90a3e92dd3727ac95afb0dde2eadecc29ee7 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri May 04 02:07:50 2018 Reland "[Layered API] Implement Layered API infrastructure behind a flag" This is a reland of bde742c2e4758ae132847b0434d516dc91892d7d This reland contains fixes for: - Issue 839236 (by adding a dependency in core/script/BUILD.gn), and - A unit test failure that caused revert https://chromium-review.googlesource.com/1042065 (by adding skip_minify flag as the minifier inserted unexpected newlines to scripts) TBR=kinuko@chromium.org,kouhei@chromium.org Original change's description: > [Layered API] Implement Layered API infrastructure behind a flag > > This CL > 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), > 2. Then maps to std-internal://x/index.js (not spec'ed [2]) > in GetInternalURL(), > 3. Then retrieves and serves the script contents for std-internal: > URLs in GetSourceText() using ui::ResourceBundle() > from blink_resources.pak. > > The source JavaScript files for Layered APIs are placed under > third_party/blink/renderer/core/script/resources/layered_api > and bundled into blink_resources.pak. > > This CL introduces std: and std-internal: schemes that are used in Blink side > (std: is user-facing while std-internal: is mostly invisible for users) > but not outside Blink. > > [1] Spec: > https://github.com/drufball/layered-apis/blob/master/spec.md > [2] Implementation design doc: > https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit > > Bug: 829084 > Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 > Reviewed-on: https://chromium-review.googlesource.com/1013321 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555524} Bug: 829084, 839236 Change-Id: I37ed111cf924b52f5998c1e6a2b6dd7d1965c813 Reviewed-on: https://chromium-review.googlesource.com/1042616 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555961} [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/public/blink_resources.grd [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.h [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/script/BUILD.gn [add] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/script/layered_api.cc [add] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/script/layered_api.h [add] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/script/layered_api_test.cc [modify] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/script/modulator.cc [add] https://crrev.com/cade90a3e92dd3727ac95afb0dde2eadecc29ee7/third_party/blink/renderer/core/script/resources/layered_api/blank/index.js
All related CLs have landed: - Infra (reland) r555961 https://chromium-review.googlesource.com/1042616 - virtual-list r555963 https://chromium-review.googlesource.com/1031749 - async-local-storage r555967 https://chromium-review.googlesource.com/1033713
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdf1be68427689f3fd350783aab3d656e2b18086 commit cdf1be68427689f3fd350783aab3d656e2b18086 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue May 08 21:17:01 2018 [Layered API] Allow relative URLs as fallback URLs Bug: 829084 Change-Id: I2d36e8bc8c74f2c3158ecb4ccc4d2a8ca6e35cc1 Reviewed-on: https://chromium-review.googlesource.com/1045085 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#556959} [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/script/layered_api.cc [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/script/layered_api.h [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/script/layered_api_test.cc [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/script/modulator.cc [modify] https://crrev.com/cdf1be68427689f3fd350783aab3d656e2b18086/third_party/blink/renderer/core/script/modulator_impl_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e95ea29443ea77661c0c32562ceadb2624cdb398 commit e95ea29443ea77661c0c32562ceadb2624cdb398 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Aug 17 15:31:38 2018 [Layered API] Disable fallback syntax Bug: 864748 , 829084 Change-Id: I164d3a83345ca9fe02a31f6a09d7fc646299a436 Reviewed-on: https://chromium-review.googlesource.com/1141105 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#584077} [modify] https://crrev.com/e95ea29443ea77661c0c32562ceadb2624cdb398/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc [modify] https://crrev.com/e95ea29443ea77661c0c32562ceadb2624cdb398/third_party/blink/renderer/core/script/layered_api.cc [modify] https://crrev.com/e95ea29443ea77661c0c32562ceadb2624cdb398/third_party/blink/renderer/core/script/layered_api.h [modify] https://crrev.com/e95ea29443ea77661c0c32562ceadb2624cdb398/third_party/blink/renderer/core/script/layered_api_test.cc [modify] https://crrev.com/e95ea29443ea77661c0c32562ceadb2624cdb398/third_party/blink/renderer/core/script/modulator_impl_base.cc
This should not be Pri-1, which means an issue to be fixed for the current milestone.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38378582dbc1eeeb6febecbb78b40d6862e8f5e0 commit 38378582dbc1eeeb6febecbb78b40d6862e8f5e0 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Jan 18 04:21:35 2019 Split Layered API-related resources into a GRDP file in core/script In order to avoid blink/public/OWNERs for every new/removed files under core/script/resources/layered_api/, this CL splits layered-API-related resources into core/script/resources/layered_api/resources.grdp. Bug: 829084 Change-Id: I5bcb541e4b639531b98ea77412318217fdd9a56c Reviewed-on: https://chromium-review.googlesource.com/c/1414152 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#624008} [modify] https://crrev.com/38378582dbc1eeeb6febecbb78b40d6862e8f5e0/third_party/blink/public/blink_resources.grd [add] https://crrev.com/38378582dbc1eeeb6febecbb78b40d6862e8f5e0/third_party/blink/renderer/core/script/resources/layered_api/resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe53869f430bce36d38c3b946ec07d14d6ed7d81 commit fe53869f430bce36d38c3b946ec07d14d6ed7d81 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Sat Jan 19 02:00:31 2019 Add generate script for Layered API resource grdp/h files. To remove manual editing of .grdp and .h files for each LAPI JS file addition/removal, this CL adds a generator script that generates these files. This CL also adds README.md for how to use the generator. Bug: 829084 Change-Id: I4faff75d14a63e675ad8c9ce5e5c1ecee5ac94f2 Reviewed-on: https://chromium-review.googlesource.com/c/1413502 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624412} [modify] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/BUILD.gn [add] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/generate_lapi_grdp.py [modify] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/layered_api.cc [modify] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/layered_api.h [add] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/layered_api_resources.h [add] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/resources/layered_api/README.md [modify] https://crrev.com/fe53869f430bce36d38c3b946ec07d14d6ed7d81/third_party/blink/renderer/core/script/resources/layered_api/resources.grdp
Comment 1 by bugdroid1@chromium.org
, Apr 27 2018