New issue
Advanced search Search tips

Issue 829083 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK hit in BluetoothLowEnergyWeavePacketReceiver::GetReasonToClose()

Project Member Reported by jlklein@chromium.org, Apr 4 2018

Issue description

Chrome Version       : 67.0.3389.0
OS Version: 10509.0.0

Run with DCHECKS on head on eve. Getting this crash repeatedly:

[21315:21315:0404/142736.341693:FATAL:bluetooth_low_energy_weave_packet_receiver.cc(54)] Check failed: state_ == State::ERROR_DETEC
TED. 
#0 0x57426fb2f36c base::debug::StackTrace::StackTrace()
#1 0x57426fb4e680 logging::LogMessage::~LogMessage()
#2 0x57427248f0b4 cryptauth::weave::BluetoothLowEnergyWeavePacketReceiver::GetReasonToClose()
#3 0x5742724890cc cryptauth::weave::BluetoothLowEnergyWeaveClientConnection::ClearQueueAndSendConnectionClose()
#4 0x57427248a812 cryptauth::weave::BluetoothLowEnergyWeaveClientConnection::Disconnect()
#5 0x5742742f2123 cryptauth::SecureChannel::Disconnect()
#6 0x574272a17b44 chromeos::tether::BleConnectionManager::UnregisterRemoteDevice()
#7 0x574272a22283 chromeos::tether::MessageTransferOperation::UnregisterDevice()
#8 0x574272a372d6 chromeos::tether::HostScannerOperation::OnMessageReceived()
#9 0x574272a22f2e chromeos::tether::MessageTransferOperation::OnMessageReceived()
#10 0x574272a16875 chromeos::tether::BleConnectionManager::NotifyMessageReceived()
#11 0x574272a16633 chromeos::tether::BleConnectionManager::ConnectionMetadata::OnMessageReceived()
#12 0x5742742f2980 cryptauth::SecureChannel::OnMessageDecoded()
#13 0x57426da87974 _ZN4base8internal7InvokerINS0_9BindStateIMN7content11SavePackageEFvRKNS_17RepeatingCallbackIFvPN8download12Downl
oadItemEEEEPNS6_16DownloadItemImplEEJNS_7WeakPtrIS4_EESA_EEEFvSE_EE3RunEPNS0_13BindStateBaseESE_
#14 0x57427246f0e7 cryptauth::DeviceToDeviceSecureContext::HandleUnwrapResult()
#15 0x57427246ecf7 _ZN4base8internal7InvokerINS0_9BindStateIMN9cryptauth29DeviceToDeviceInitiatorHelperEFvRKNS4_35ValidateResponder
AuthMessageContextEbRKNSt3__112basic_stringIcNS8_11char_traitsIcEENS8_9allocatorIcEEEERKN13securemessage6HeaderEEJNS_7WeakPtrIS4_EE
S5_EEEFvbSG_SK_EE3RunEPNS0_13BindStateBaseEbSG_SK_
#16 0x574272473776 cryptauth::(anonymous namespace)::HandleUnwrapResult()
#17 0x5742705fd458 chromeos::(anonymous namespace)::EasyUnlockClientImpl::OnData()
#18 0x5742705fa416 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos12_GLOBAL__N_119CrosDisksClientImplEFvNS_12OnceCallbackIFvbE
EEPN4dbus8ResponseEEJNS_7WeakPtrIS5_EES8_EEEFvSB_EE7RunOnceEPNS0_13BindStateBaseESB_
#19 0x57427076e95d dbus::ObjectProxy::OnCallMethod()
#20 0x574270772b91 _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9alloc
atorIcEEEESC_NS_12OnceCallbackIFvPNS2_8ResponseEEEESF_PNS2_13ErrorResponseEEvE6InvokeI13scoped_refptrIS3_EJSA_SA_SH_SF_SJ_EEEvSL_OT
_DpOT0_
#21 0x574270772a99 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS
5_9allocatorIcEEEESD_NS_12OnceCallbackIFvPNS3_8ResponseEEEESG_PNS3_13ErrorResponseEEJ13scoped_refptrIS4_ESB_SB_SI_EEEFvSG_SK_EE7Run
OnceEPNS0_13BindStateBaseESG_SK_
#22 0x57427076f184 dbus::ObjectProxy::RunResponseOrErrorCallback()
#23 0x574270773e98 _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEP
NS2_13ErrorResponseEEvE6InvokeI13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvSB_OT_DpOT0_
#24 0x574270773da0 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8Re
sponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#25 0x57426fbb30c8 base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()
#26 0x57426fb2fbed base::debug::TaskAnnotator::RunTask()
#27 0x57426fbfbe46 base::internal::IncomingTaskQueue::RunTask()
#28 0x57426fb56ad6 base::MessageLoop::RunTask()
#29 0x57426fb56ef7 base::MessageLoop::DeferOrRunPendingTask()
#30 0x57426fb57188 base::MessageLoop::DoWork()
#31 0x57426fb59509 base::MessagePumpLibevent::Run()
#32 0x57426fb5634c base::MessageLoop::Run()
#33 0x57426fb859c6 base::RunLoop::Run()
#34 0x57426f758a47 ChromeBrowserMainParts::MainMessageLoopRun()
#35 0x57426d9683b4 content::BrowserMainLoop::RunMainMessageLoopParts()
#36 0x57426d96b753 content::BrowserMainRunnerImpl::Run()
#37 0x57426d96405d content::BrowserMain()
#38 0x57426f73e944 content::RunNamedProcessTypeMain()
#39 0x57426f73fa53 content::ContentMainRunnerImpl::Run()
#40 0x57426f74c23e service_manager::Main()
#41 0x57426f73de31 content::ContentMain()
#42 0x57426cb598df ChromeMain
#43 0x7fc9f262b736 __libc_start_main
#44 0x57426cb596f9 _start

 
dchecklogs.zip
7.5 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad260293e6811dded924eae6934aa4c245a53141

commit ad260293e6811dded924eae6934aa4c245a53141
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Apr 04 23:19:27 2018

[CrOS Tether] Remove erroneous DCHECK().

The DCHECK() asserted that the status was ERROR_DETECTED whenever
GetReasonToClose() was called. However, this function is also intended
to be called when connections are closed normally.

Bug:  829083 
Change-Id: Iaee6948cf38ef3ee3ddfbde8681ec9a840928662
Reviewed-on: https://chromium-review.googlesource.com/996310
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548241}
[modify] https://crrev.com/ad260293e6811dded924eae6934aa4c245a53141/components/cryptauth/ble/bluetooth_low_energy_weave_packet_receiver.cc

Status: Fixed (was: Assigned)

Sign in to add a comment