New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829064 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[cr-audit-commits] The usage of the metadata field in RuleResult is potentially confusing.

Project Member Reported by robert...@chromium.org, Apr 4 2018

Issue description

There are concerns that the current approach of providing .GetToken and .SetToken methods for the RuleResult struct (which parse and mutate the contents of the .Metadata string field of the struct, respectively) could be confusing to users.

Metadata is an unindexed string field and is meant for audit rules to pass arbitrary data to notification functions that go beyond the human-readable .Message property.

One possible solution is to remove these as methods to avoid imposing on users the usage pattern consisting on essentially using a string to store a string-to-string map.
 
For context, see the post-merge comments on this changelist: https://chromium-review.googlesource.com/c/infra/infra/+/982756
Components: Infra>Audit
Components: -Tools>Test>FindIt

Sign in to add a comment