New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829054 link

Starred by 1 user
Status: Verified
Owner:
█ allenvic@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
baileyberro@chromium.org
zentaro@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Crash when copying directory from local disk to share

Project Member Reported by allenvic@chromium.org, Apr 4 2018 
The crash occurs since the files api in Chrome tries to delete the directory being copied from the destination, and if there
was nothing to delete, GetDeleteList returns an error since it could not get the metadata of a non-existent entry. The call then returns with an invalid file descriptor.


What is the expected result?

Successfully copy the directory.

What happens instead?

Crash
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cbbe2bc235e68e440755b19f06002aac7d21603a

commit cbbe2bc235e68e440755b19f06002aac7d21603a
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Apr 19 23:25:16 2018

smbprovider: Fix for crash when copying directory to share

This fixes the crash that occurs when a directory is copied from local
disk to the share by generating a valid file descriptor even in the case
of an error.

BUG= chromium:829054 
TEST=successfully copies a directory from local disk
Change-Id: I64d1a2affeec14b8f79094dd121f6fd750ef0c86
Reviewed-on: https://chromium-review.googlesource.com/996515
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/cbbe2bc235e68e440755b19f06002aac7d21603a/smbprovider/smbprovider.cc
[modify] https://crrev.com/cbbe2bc235e68e440755b19f06002aac7d21603a/smbprovider/smbprovider.h
[modify] https://crrev.com/cbbe2bc235e68e440755b19f06002aac7d21603a/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/cbbe2bc235e68e440755b19f06002aac7d21603a/smbprovider/temp_file_manager.h

Comment 2 by allenvic@chromium.org, Apr 23 2018

Status: Verified (was: Untriaged)
Fixed with https://chromium-review.googlesource.com/c/chromiumos/platform2/+/996515
►

Sign in to add a comment