New issue
Advanced search Search tips

Issue 829045 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK hit in GPUProcessHost via ArcOEMCryptoBridge

Project Member Reported by jlklein@chromium.org, Apr 4 2018

Issue description

Chrome Version       : 67.0.3389.0
OS Version: 10509.0.0


Built from head and enabled dchecks and now I'm stuck in a crash loop:


Received signal 6
#0 0x56267e37241c base::debug::StackTrace::StackTrace()
#1 0x56267e371ef1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7ddc69f4a2e0 <unknown>
#3 0x7ddc68fd3dd2 gsignal
#4 0x7ddc68fd5bf6 abort
#5 0x56267e370785 base::debug::BreakDebugger()
#6 0x56267e391bb9 logging::LogMessage::~LogMessage()
#7 0x56267c362ae1 content::GpuProcessHost::Get()
#8 0x56267c0707fd content::BindInterfaceInGpuProcess()
#9 0x56267ce376af content::BindInterfaceInGpuProcess<>()
#10 0x56267ce36d55 arc::ArcOemCryptoBridge::ConnectToDaemon()
#11 0x56267ce36b7c arc::ArcOemCryptoBridge::OnBootstrapMojoConnection()
#12 0x56267ce3842e _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN3arc18ArcOemCryptoBridgeEFvN4mojo16InterfaceRequestINS4_5mojom16OemCryptoServiceEEEbENS_7WeakPtrIS5_EEJSA_bEEEvOT_OT0_DpOT1_
#13 0x56267ce38311 _ZN4base8internal7InvokerINS0_9BindStateIMN3arc18ArcOemCryptoBridgeEFvN4mojo16InterfaceRequestINS3_5mojom16OemCryptoServiceEEEbEJNS_7WeakPtrIS4_EES9_EEEFvbEE7RunOnceEPNS0_13BindStateBaseEb
#14 0x56267ee3d399 chromeos::(anonymous namespace)::CrosDisksClientImpl::OnVoidMethod()
#15 0x56267ee3d4c6 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos12_GLOBAL__N_119CrosDisksClientImplEFvNS_12OnceCallbackIFvbEEEPN4dbus8ResponseEEJNS_7WeakPtrIS5_EES8_EEEFvSB_EE7RunOnceEPNS0_13BindStateBaseESB_
#16 0x56267efb1a0d dbus::ObjectProxy::OnCallMethod()
#17 0x56267efb5c41 _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEESC_NS_12OnceCallbackIFvPNS2_8ResponseEEEESF_PNS2_13ErrorResponseEEvE6InvokeI13scoped_refptrIS3_EJSA_SA_SH_SF_SJ_EEEvSL_OT_DpOT0_
#18 0x56267efb5b49 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEESD_NS_12OnceCallbackIFvPNS3_8ResponseEEEESG_PNS3_13ErrorResponseEEJ13scoped_refptrIS4_ESB_SB_SI_EEEFvSG_SK_EE7RunOnceEPNS0_13BindStateBaseESG_SK_
#19 0x56267efb2234 dbus::ObjectProxy::RunResponseOrErrorCallback()
#20 0x56267efb6f48 _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEPNS2_13ErrorResponseEEvE6InvokeI13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvSB_OT_DpOT0_
#21 0x56267efb6e50 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#22 0x56267e3f6178 base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()
#23 0x56267e372c9d base::debug::TaskAnnotator::RunTask()
#24 0x56267e43eef6 base::internal::IncomingTaskQueue::RunTask()
#25 0x56267e399b86 base::MessageLoop::RunTask()
#26 0x56267e399fa7
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53db36ef15e116e8b264735f2b342c447cfe387b

commit 53db36ef15e116e8b264735f2b342c447cfe387b
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Thu Apr 05 23:24:40 2018

Fixed threading for GPU interface for ArcOemCrypto

This fixes a DCHECK crash where we were making a call to bind the GPU
interface that wasn't called on the IO thread. It now makes a call on
the IO thread to get the interface which then posts a task back to the
original thread to then complete the Mojo call.

Bug:  829045 
Test: Verified DCHECK is gone and L1 DRM still works
Change-Id: Ia10ce58a2ecef071f33cfc48a49c72af3bc23a8c
Reviewed-on: https://chromium-review.googlesource.com/998530
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548611}
[modify] https://crrev.com/53db36ef15e116e8b264735f2b342c447cfe387b/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/53db36ef15e116e8b264735f2b342c447cfe387b/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.h

Status: Fixed (was: Assigned)

Sign in to add a comment