Infobars stacked on top of each other |
||||
Issue descriptionChrome: 67.0.3387.0 VRCore: 1.13.185188193 Android N Device: S8+ What steps will reproduce the problem? (1) Go to a secure site, e.g mobile.nytimes.com (2) Click on the secure site padlock icon in the url bar to display infobar. (3) Click on the details link. What is the expected result? Not sure, maybe an improved UI. What happens instead? 2 stacked infobars. See screenshot.
,
Apr 4 2018
I dunno, you sure this needs fixing? Seems fine to me.
,
Apr 4 2018
Per internal discussion, will hide the site info dialog before showing the exit prompt.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba98a5acf0ae0d5d244407fca56cb5b1af48fed6 commit ba98a5acf0ae0d5d244407fca56cb5b1af48fed6 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Apr 05 01:32:31 2018 Close page info dialog before exit VR request After the user clicks on details on the page info dialog always dismiss the page info dialog. By doing so, the dialog disappears in VR before showing the user the exit VR request. That is consistent with what happens when the user clicks the site settings button. Bug: 829043 Change-Id: Id51477f08cf693107d11044c7ca2ec477c0118f8 Reviewed-on: https://chromium-review.googlesource.com/996305 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#548284} [modify] https://crrev.com/ba98a5acf0ae0d5d244407fca56cb5b1af48fed6/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java [modify] https://crrev.com/ba98a5acf0ae0d5d244407fca56cb5b1af48fed6/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Apr 5 2018
,
May 8 2018
Verified on build 67.0.3396.29 beta. Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tiborg@chromium.org
, Apr 4 2018