New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829039 link

Starred by 1 user
Status: Fixed
Owner:
█ jhawkins@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
█ jlklein@chromium.org
khorimoto@chromium.org
█ sacomoto@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
█ tengs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 828481


Sign in to add a comment

Remove "bluetooth_address" field from cryptauth::RemoteDevice

Project Member Reported by khorimoto@chromium.org, Apr 4 2018 
This field was only used by the BT classic flow, which has been removed.

However, much of the chrome.easyUnlockPrivate API still has Bluetooth address-related functionality:
  *the Device message still has a bluetoothAddress field
  *several API functions still use the field (e.g., chrome.easyUnlockPrivate.seekBluetoothDeviceByAddress())

Since this interfaces with the Chrome App, references to these fields/functions must be removed from the Chrome App before they can be removed from the C++ code.

Comment 1 by jhawkins@chromium.org, Apr 4 2018 

Kyle, is there something specific you believe is still being referenced in the Chrome app?  All of the Bluetooth Classic code should be gone.

Comment 2 by khorimoto@chromium.org, Apr 4 2018 

Here's the chrome.easyUnlockPrivate IDL file:

https://cs.chromium.org/chromium/src/chrome/common/extensions/api/easy_unlock_private.idl

The "Device" dictionary still contains a bluetoothDevice field, and there are still several functions which either return an address or take an address as a parameter. These functions also have associated implementations located here:

https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h

Once these references are removed, we can eliminate the field from the cryptauth::RemoteDevice object.

Comment 3 by khorimoto@chromium.org, Apr 4 2018

Summary: Remove "bluetooth_address" field from cryptauth::RemoteDevice (was: Remote "bluetooth_address" field from cryptauth::RemoteDevice)

Comment 4 by jhawkins@chromium.org, Apr 4 2018 

My question in comment #1 is about your reference to the Chrome App, not about the actual interface (which as far as I understand is ready to be deleted).  Please answer the question about the Chrome App source from comment #1.

Comment 5 by khorimoto@chromium.org, Apr 4 2018 

Sorry, I wasn't clear in comment #1 - I believe you've removed references to those functions in the Chrome App already. What I meant is that the API references need to be removed so that they are no longer exposed to the Chrome App at all.

Comment 6 by jhawkins@chromium.org, Apr 4 2018

Blockedon: 828481
Got it, thanks.  This is blocked on updating the Chrome App in the CrOS repository ( crbug.com/828481 ).
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04cba1ef720980ebe28a3ffd139f609b6e8d8084

commit 04cba1ef720980ebe28a3ffd139f609b6e8d8084
Author: Kyle Horimoto <khorimoto@google.com>
Date: Tue Apr 10 01:58:17 2018

[CrOS MultiDevice] RemoteDevice::operator==: Don't consider BT address.

Now that [1] has landed, RemoteDevice objects sent over a Mojo API
undergo a translation from cryptauth::RemoteDevice to
device_sync::mojom::RemoteDevice, then back to cryptauth::RemoteDevice
on the other side of the pipe. This translation does not include the
RemoteDevice's Bluetooth address, so if a RemoteDevice has an address
defined before it is sent over the pipe, it will be lost in translation.

Thus, the address should not be compared in RemoteDevice::operator==.

This is part of an ongoing effort to remote the address field
altogether, since it was only used in EasyUnlock v1 (now deprecated).

[1] https://chromium-review.googlesource.com/c/chromium/src/+/996642

Bug:  829039 , 824568,  752273 
Change-Id: I122df1d3e93227136309d18964db1f8c88c4a449
Reviewed-on: https://chromium-review.googlesource.com/1003516
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549373}
[modify] https://crrev.com/04cba1ef720980ebe28a3ffd139f609b6e8d8084/components/cryptauth/remote_device.cc

Comment 8 by jhawkins@chromium.org, Apr 12 2018

Status: Started (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac76f9837a98a135e490b2a0713b582589584396

commit ac76f9837a98a135e490b2a0713b582589584396
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Apr 13 03:37:17 2018

extensions/EasyUnlockPrivateApi: Remove unused bluetoothAddress field.

R=khorimoto@chromium.org, tbarzic@chromium.org

Bug:  829039 
Test: none
Change-Id: I25c885d2bbed34146dc313e2298384e90b00e425
Reviewed-on: https://chromium-review.googlesource.com/1011345
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550490}
[modify] https://crrev.com/ac76f9837a98a135e490b2a0713b582589584396/chrome/common/extensions/api/easy_unlock_private.idl
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a774c419063fd86a2bbabe2cec0790eff7faf8

commit b0a774c419063fd86a2bbabe2cec0790eff7faf8
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Apr 16 17:29:05 2018

components/cryptauth: Remove unused bluetooth_address field from RemoteDevice.

R=hansberry@chromium.org

Bug:  829039 
Test: none
Change-Id: I4216ffa94963a3f2bfdab08b73dd135fd78f4007
Reviewed-on: https://chromium-review.googlesource.com/1012981
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551021}
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/connection.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/connection.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/connection_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/cryptauth_test_util.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/fake_connection.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/fake_connection.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device_loader.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device_loader_unittest.cc

Comment 11 by jhawkins@chromium.org, Apr 16 2018

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac76f9837a98a135e490b2a0713b582589584396

commit ac76f9837a98a135e490b2a0713b582589584396
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Apr 13 03:37:17 2018

extensions/EasyUnlockPrivateApi: Remove unused bluetoothAddress field.

R=khorimoto@chromium.org, tbarzic@chromium.org

Bug:  829039 
Test: none
Change-Id: I25c885d2bbed34146dc313e2298384e90b00e425
Reviewed-on: https://chromium-review.googlesource.com/1011345
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550490}
[modify] https://crrev.com/ac76f9837a98a135e490b2a0713b582589584396/chrome/common/extensions/api/easy_unlock_private.idl
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a774c419063fd86a2bbabe2cec0790eff7faf8

commit b0a774c419063fd86a2bbabe2cec0790eff7faf8
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Apr 16 17:29:05 2018

components/cryptauth: Remove unused bluetooth_address field from RemoteDevice.

R=hansberry@chromium.org

Bug:  829039 
Test: none
Change-Id: I4216ffa94963a3f2bfdab08b73dd135fd78f4007
Reviewed-on: https://chromium-review.googlesource.com/1012981
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551021}
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/connection.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/connection.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/connection_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/cryptauth_test_util.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/fake_connection.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/fake_connection.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device.h
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device_loader.cc
[modify] https://crrev.com/b0a774c419063fd86a2bbabe2cec0790eff7faf8/components/cryptauth/remote_device_loader_unittest.cc
►

Sign in to add a comment