Update the origin field when showing a safe browsing interstitial |
||||
Issue descriptionUpdate the origin field when showing a safe browsing interstitial.
,
Apr 4 2018
What it looks like instead:
,
Apr 5 2018
Thank you for volunteering to look into this a bit, Anthony.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ceb36b992e44a76bcab6b549eb5213105ccbd17 commit 0ceb36b992e44a76bcab6b549eb5213105ccbd17 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Thu Apr 05 22:30:08 2018 [Web Payments] Update origin in PH header when interstitial is shown This change displays the Visible URL in the PH header instead of the last committed. Moreover, it updates the header when an interstitial (such as Safe Browsing) is attached or detached. Bug: 829027 Change-Id: Ie1fd0f9f404d571587f4980687bb170d036e76a0 Reviewed-on: https://chromium-review.googlesource.com/998750 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#548589} [modify] https://crrev.com/0ceb36b992e44a76bcab6b549eb5213105ccbd17/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc [modify] https://crrev.com/0ceb36b992e44a76bcab6b549eb5213105ccbd17/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h
,
Apr 6 2018
Tried testing the issue on mac 10.13.3, win-10 and ubuntu 14.04 using latest chrome version #67.0.3390.0 by navigating to https://rsolomakhin.github.io/pr/bob/ and https://badssl.com/ Observed that on "bob pay test" page, cannot make payment error was shown and on navigating to https://self-signed.badssl.com/, it showed a connection not private message. Attached a screen cast for reference. anthonyvd@ - Could you please check the attached screen cast and please let us know the expected behaviour and please confirm the fix. Thanks...!!
,
May 30 2018
Ping anthony
,
Nov 6
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rouslan@chromium.org
, Apr 4 201874.8 KB
74.8 KB View Download