New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829027 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Update the origin field when showing a safe browsing interstitial

Project Member Reported by rouslan@chromium.org, Apr 4 2018

Issue description

Update the origin field when showing a safe browsing interstitial.
 
What the URL display should look like with a safe browsing interstitial:
Screenshot from 2018-04-04 16-14-54.png
74.8 KB View Download
What it looks like instead:
Screenshot from 2018-04-03 21-00-03.png
119 KB View Download
Cc: rouslan@chromium.org
Owner: anthonyvd@chromium.org
Thank you for volunteering to look into this a bit, Anthony.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ceb36b992e44a76bcab6b549eb5213105ccbd17

commit 0ceb36b992e44a76bcab6b549eb5213105ccbd17
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Apr 05 22:30:08 2018

[Web Payments] Update origin in PH header when interstitial is shown

This change displays the Visible URL in the PH header instead of the
last committed. Moreover, it updates the header when an interstitial
(such as Safe Browsing) is attached or detached.

Bug:  829027 
Change-Id: Ie1fd0f9f404d571587f4980687bb170d036e76a0
Reviewed-on: https://chromium-review.googlesource.com/998750
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548589}
[modify] https://crrev.com/0ceb36b992e44a76bcab6b549eb5213105ccbd17/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc
[modify] https://crrev.com/0ceb36b992e44a76bcab6b549eb5213105ccbd17/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tried testing the issue on mac 10.13.3, win-10 and ubuntu 14.04 using latest chrome version #67.0.3390.0 by navigating to https://rsolomakhin.github.io/pr/bob/ and https://badssl.com/
Observed that on "bob pay test" page, cannot make payment error was shown and on navigating to https://self-signed.badssl.com/, it showed a connection not private message.
Attached a screen cast for reference.

anthonyvd@ - Could you please check the attached screen cast and please let us know the expected behaviour and please confirm the fix.

Thanks...!!
829027.mp4
649 KB View Download

Comment 6 by ma...@chromium.org, May 30 2018

Ping anthony
Status: Fixed (was: Assigned)

Sign in to add a comment