New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829004 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility



Sign in to add a comment

Add sounds resources for Dictation

Project Member Reported by dtseng@chromium.org, Apr 4 2018

Issue description

Tracking bug for dictation sound resources.

Note: currently, we use placeholders sounds taken from ChromeVox. Please replace those references to the new dictation sounds.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b89fef49642bc29ae7be1d1443687a85f337bb0d

commit b89fef49642bc29ae7be1d1443687a85f337bb0d
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Thu Apr 12 21:38:54 2018

Update ChromeOS Dictation to use approved earcons

Replacing placeholder sounds taken from ChromeVox.

Bug:  829004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3aec21ab109b6afafab677b97d11de0df4fc5bfb
Reviewed-on: https://chromium-review.googlesource.com/999031
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550371}
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/chromeos/accessibility/dictation_chromeos.cc
[add] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/resources/chromeos/sounds/earcons/audio_end.wav
[add] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/resources/chromeos/sounds/earcons/audio_initiate.wav
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chromeos/audio/chromeos_sounds.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b89fef49642bc29ae7be1d1443687a85f337bb0d

commit b89fef49642bc29ae7be1d1443687a85f337bb0d
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Thu Apr 12 21:38:54 2018

Update ChromeOS Dictation to use approved earcons

Replacing placeholder sounds taken from ChromeVox.

Bug:  829004 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3aec21ab109b6afafab677b97d11de0df4fc5bfb
Reviewed-on: https://chromium-review.googlesource.com/999031
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550371}
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/chromeos/accessibility/dictation_chromeos.cc
[add] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/resources/chromeos/sounds/earcons/audio_end.wav
[add] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chrome/browser/resources/chromeos/sounds/earcons/audio_initiate.wav
[modify] https://crrev.com/b89fef49642bc29ae7be1d1443687a85f337bb0d/chromeos/audio/chromeos_sounds.h

Status: Fixed (was: Assigned)

Sign in to add a comment