New issue
Advanced search Search tips

Issue 828999 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on: View detail
issue 862850
issue 864675
issue 864680
issue 864682
issue 864683
issue 864684
issue 864686
issue 852557
issue 862851
issue 862852
issue 862853
issue 864677
issue 864679

Blocking:
issue 893722



Sign in to add a comment

Eng tracking for "Show off" app for new feature discovery and setup

Project Member Reported by zalcorn@chromium.org, Apr 4 2018

Issue description

Blockedon: 852557
Blockedon: 862850
Blockedon: 862851
Blockedon: 862852
Blockedon: 862853
Blockedon: 864675
Blockedon: 864677
Blockedon: 864679
Blockedon: 864680
Blockedon: 864682
Blockedon: 864683
Blockedon: 864684
Blockedon: 864686
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c466f89410b80d4fe5aad66f7de507138c6a0416

commit c466f89410b80d4fe5aad66f7de507138c6a0416
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Jul 17 23:51:05 2018

Chrome OS: Implement Discover UI infrastructure.

This Cl adds basic elements of the Discover App: DiscoverManager,
DiscoverUI, DiscoverModule, etc...

Bug: 828999

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I526032df033d68bfae4583e9872262ad8af79219
Reviewed-on: https://chromium-review.googlesource.com/1103457
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575847}
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_WELCOME_GET_STARTED.png.sha1
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_WELCOME_LATER.png.sha1
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_WELCOME_SUBTITLE.png.sha1
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_WELCOME_TITLE.png.sha1
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/browser_process_platform_part_chromeos.h
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/browser_resources.grd
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/screens/discover_screen.cc
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/screens/discover_screen.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/screens/discover_screen_view.h
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_app.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_app.js
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_card.css
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_card.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_card.js
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_card_host.css
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_components.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_components.js
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_ui.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_ui.js
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_welcome.css
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_welcome.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/discover/discover_welcome.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/md_login_screens.html
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/oobe_dialog_host.css
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/oobe_dialog_host_behavior.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/oobe_screens.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/screen_discover.html
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/resources/chromeos/login/screen_discover.js
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_handler.cc
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_handler.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/discover_ui.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover_screen_handler.cc
[add] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/discover_screen_handler.h
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/c466f89410b80d4fe5aad66f7de507138c6a0416/ui/login/display_manager.js

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bb52e3acab110975a7623c656d04179920a79fc

commit 6bb52e3acab110975a7623c656d04179920a79fc
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 01 22:59:31 2018

Chrome OS OOBE: Fix alignment of hd-iron-icon element.

Bug: 828999
Change-Id: I2be47264b2b3140e777b6d711e36b87bfa40daed
Reviewed-on: https://chromium-review.googlesource.com/1157914
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579976}
[modify] https://crrev.com/6bb52e3acab110975a7623c656d04179920a79fc/chrome/browser/resources/chromeos/login/hd-iron-icon.html

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb

commit 7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 01 23:00:34 2018

ChromeOS OOBE: Make sure all oobe-dialog receive onBeforeShow event.

This CL routes onBeforeShow event to the oobe-dialogs, that are not subnodes
of another Polymer object.

Bug: 828999
Change-Id: Id2cee750d2364e53052133bbea7d27ea2c1ca0a2
Reviewed-on: https://chromium-review.googlesource.com/1157912
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579977}
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/chrome/browser/resources/chromeos/login/oobe_reset.js
[modify] https://crrev.com/7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb/ui/login/display_manager.js

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 11

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0728c3e926a4f933c183c82c7b6eb3195156fd30

commit 0728c3e926a4f933c183c82c7b6eb3195156fd30
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Aug 11 02:53:28 2018

Chrome OS OOBE: Fix alignment of hd-iron-icon element.

TBR=alemate@chromium.org

(cherry picked from commit 6bb52e3acab110975a7623c656d04179920a79fc)

Bug: 828999
Change-Id: I2be47264b2b3140e777b6d711e36b87bfa40daed
Reviewed-on: https://chromium-review.googlesource.com/1157914
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579976}
Reviewed-on: https://chromium-review.googlesource.com/1171945
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#551}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/0728c3e926a4f933c183c82c7b6eb3195156fd30/chrome/browser/resources/chromeos/login/hd-iron-icon.html

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d33ccc862c495d4b76f63b9ac2720fd142919c6f

commit d33ccc862c495d4b76f63b9ac2720fd142919c6f
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Aug 11 02:54:36 2018

ChromeOS OOBE: Make sure all oobe-dialog receive onBeforeShow event.

This CL routes onBeforeShow event to the oobe-dialogs, that are not subnodes
of another Polymer object.

TBR=alemate@chromium.org

(cherry picked from commit 7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb)

Bug: 828999
Change-Id: Id2cee750d2364e53052133bbea7d27ea2c1ca0a2
Reviewed-on: https://chromium-review.googlesource.com/1157912
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579977}
Reviewed-on: https://chromium-review.googlesource.com/1171946
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#552}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/chrome/browser/resources/chromeos/login/oobe_reset.js
[modify] https://crrev.com/d33ccc862c495d4b76f63b9ac2720fd142919c6f/ui/login/display_manager.js

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6b0ab619f694b9781b0ccd8e3f7d01410f5e0c4

commit a6b0ab619f694b9781b0ccd8e3f7d01410f5e0c4
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Aug 24 21:11:05 2018

Chrome OS OOBE: Implement propagateUpdateLocalizedContent().


This CL adds OobeDialogHostBehavior::propagateUpdateLocalizedContent to
notify multilayer oobe-dialog structures of the locale change.

Bug: 828999
Change-Id: I86432fc41a12ddf50f94228aaab27e23332eb982
Reviewed-on: https://chromium-review.googlesource.com/1188487
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585990}
[modify] https://crrev.com/a6b0ab619f694b9781b0ccd8e3f7d01410f5e0c4/chrome/browser/resources/chromeos/login/oobe_dialog_host_behavior.js

Labels: -M-68 CrOSShowOff M-71
Components: Platform>Apps>ShowOff
Components: -UI>Shell>OOBE
Labels: -M-71
Blocking: 893722
Blocking: -723680
Owner: jessejames@chromium.org
This feature is currently on-pause. Jesse is the new PM for it.

Sign in to add a comment