'gclient sync' broken on Win10/CygWin |
||
Issue description'gclient sync' is calling cipd when run under Windows10/CygWin. (master) ~/chromium/src> gclient sync Syncing projects: 100% (137/137), done. ________ running 'cipd ensure -log-level error -root /cygdrive/d/src/chromium -ensure-file /tmp/tmpUGfAzG.ensure' in '.' Error: open /tmp/tmpUGfAzG.ensure: The system cannot find the file specified.. Error: Command 'cipd ensure -log-level error -root /cygdrive/d/src/chromium -ensure-file /tmp/tmpUGfAzG.ensure' returned non-zero exit status 1 This is only happening with depot_tools rev d3ba72bbc646aa52dea83a299b18620d29c36051 or later then it fails with the above error. If I go back to rev 33bf49538c3c6cbffd50dc379c811f81fdf7383d (which is back just 1 more commit) then it succeeds not running any 'cipd' command at all. So it looks to be caused by https://chromium-review.googlesource.com/955933 If 'cipd' is required now, that command is a bash script but it passes its parameters to a .cipd_client executable which is a compiled binary. Assuming its a stock Windows binary then it's not going to like paths such as /cygwin/d/src/chromium/src or /tmp/foo.ensure which explains why it is unable to find them. The .cipd_client binary is downloaded from $CIPD_CLIENT_SRV/client?platform=${PLAT}-${ARCH}&version=$CIPD_CLIENT_VER so it makes sense that it wouldn't like CygWin paths since there is nothing there to differentiate CygWin from Windows. Since the 'cipd' script recognizes running under CygWin, perhaps it could simply loop through the parameters and run 'cygpath -w $ARG' on all arguments starting with a slash (/).
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/361822cb2ddcad3813746508ef9c5b8c6e767a81 commit 361822cb2ddcad3813746508ef9c5b8c6e767a81 Author: Brian White <bcwhite@chromium.org> Date: Wed Apr 04 19:40:22 2018 Convert CygWin paths to Windows native for CIPD. Bug: 828981 Change-Id: Ibd4b31413bcdbbfe9bb1076334c892f1a30c768e Reviewed-on: https://chromium-review.googlesource.com/996432 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/361822cb2ddcad3813746508ef9c5b8c6e767a81/cipd
,
Apr 4 2018
gclient:
solutions = [
{
"managed": False,
"name": "src",
"url": "https://chromium.googlesource.com/chromium/src.git",
"deps_file": ".DEPS.git",
"safesync_url": "",
"custom_deps": {
"src/third_party/WebKit/LayoutTests": None,
"src/third_party/xulrunner-sdk": None,
"src/chrome_frame/tools/test/reference_build/chrome": None,
"src/chrome/tools/test/reference_build/chrome_mac": None,
"src/chrome/tools/test/reference_build/chrome": None,
"src/chrome/tools/test/reference_build/chrome_linux": None,
},
},
{ "name" : "src-internal",
"url" : "https://chrome-internal.googlesource.com/chrome/src-internal.git",
"deps_file" : ".DEPS.git",
},
]
src revision? You mean the git checkout?
02472a209454a042e6a248de62f324e0b8c353ad
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b6c6c3576c73c959b601fb3c0e26908b9b59f17 commit 1b6c6c3576c73c959b601fb3c0e26908b9b59f17 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 05 04:01:10 2018 Roll src/third_party/depot_tools/ a1df57cdc..2a5f70cc0 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a1df57cdc657..2a5f70cc060a $ git log a1df57cdc..2a5f70cc0 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 vadimsh Kick the recipe roller to pick up the revert. 2018-04-04 bcwhite Convert CygWin paths to Windows native for CIPD. Created with: roll-dep src/third_party/depot_tools BUG= chromium:828981 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1a08df8f756f915856265d328a28cba90b28cc76 Reviewed-on: https://chromium-review.googlesource.com/996672 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548319} [modify] https://crrev.com/1b6c6c3576c73c959b601fb3c0e26908b9b59f17/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by jbudorick@chromium.org
, Apr 4 2018