Under review at https://chromium-review.googlesource.com/c/chromium/src/+/992322

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02c5490ce8a43336110d8210747d88202352e009

commit 02c5490ce8a43336110d8210747d88202352e009
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Apr 05 17:30:07 2018

Use old download path for same-origin downloads

BUG= 828963 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7d17bfdc8f4b312ff70bba4d700c528eaabd7948
Reviewed-on: https://chromium-review.googlesource.com/992322
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548465}
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[delete] https://crrev.com/4f8cac3b9ce17615c0f60c167c2efa9b46193f17/third_party/WebKit/LayoutTests/external/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download-expected.txt
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-allow-blob-expected.txt
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-allow-data-expected.txt
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-allow-sameorigin-expected.txt
[modify] https://crrev.com/02c5490ce8a43336110d8210747d88202352e009/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Abdul, just a heads-up, I'll request merge to M66 after bake time on canary.

how much time do I have?

[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.

This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Has this fix been verified in Canary? How safe is this merge overall and why is it urgent for M66?

yep, it's been verified. It's safe (only code change is in one file, rest is test changes).

Urgency: see the list of blocked issues. 

Approving merge to M66. Branch:3359

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f871e42971ab9ff101866f970c06c871678f20c

commit 9f871e42971ab9ff101866f970c06c871678f20c
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Apr 10 07:32:51 2018

Use old download path for same-origin downloads

BUG= 828963 
TBR=jochen@chromium.org

(cherry picked from commit 02c5490ce8a43336110d8210747d88202352e009)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7d17bfdc8f4b312ff70bba4d700c528eaabd7948
Reviewed-on: https://chromium-review.googlesource.com/992322
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#548465}
Reviewed-on: https://chromium-review.googlesource.com/1004575
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#643}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[delete] https://crrev.com/2d43a235450079123130771de42f6c359e29bc6c/third_party/WebKit/LayoutTests/external/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404-expected.txt
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download-expected.txt
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-allow-blob-expected.txt
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-allow-data-expected.txt
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/third_party/WebKit/LayoutTests/http/tests/security/anchor-download-allow-sameorigin-expected.txt
[modify] https://crrev.com/9f871e42971ab9ff101866f970c06c871678f20c/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a774e4b06c7a5d00541a330a1b0f8d13cc187e9

commit 9a774e4b06c7a5d00541a330a1b0f8d13cc187e9
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Apr 10 09:41:54 2018

Fix compile after 9f871e42971ab9ff101866f970c06c871678f20c

TBR=mkwst@chromium.org
BUG= 828963 

Change-Id: Ied6f10f9abf21ee00df0656674afb18453c676b3
Reviewed-on: https://chromium-review.googlesource.com/1004894
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#645}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/9a774e4b06c7a5d00541a330a1b0f8d13cc187e9/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

 Issue 832091  has been merged into this issue.

Able to reproduce this issue on Windows 10, Ubuntu 14.04 and Mac OS 10.13.3 on the reported version 65.0.3325.181 and the issue is fixed on the latest Stable 66.0.3359.117 as per  issue 832091 .

On adding the given extension and clicking on the download link, file download is triggered.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..

Deleted: 832091-M66.webm 1.1 MB

	832091-M66.webm 1.1 MB View Download

 Issue 822542  has been merged into this issue.