"FilenameUtilTest.GenerateSafeFileName" is flaky |
|||
Issue description"FilenameUtilTest.GenerateSafeFileName" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVGaWxlbmFtZVV0aWxUZXN0LkdlbmVyYXRlU2FmZUZpbGVOYW1lDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d99093493b794c71261e51e7f66bfc764e2dde3a commit d99093493b794c71261e51e7f66bfc764e2dde3a Author: Darren Shen <shend@chromium.org> Date: Thu Apr 05 05:06:24 2018 Disable flaky FilenameUtilTest.GenerateSafeFileName test TBR=asanka@chromium.org Bug: 828954 Change-Id: Ifb43987ec0e7e892e6655d4f1469b57daae50be6 Reviewed-on: https://chromium-review.googlesource.com/997055 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#548335} [modify] https://crrev.com/d99093493b794c71261e51e7f66bfc764e2dde3a/net/base/filename_util_unittest.cc
,
Apr 5 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/090f40e09d091ba08659ba9f1ad0111f90e000d4 commit 090f40e09d091ba08659ba9f1ad0111f90e000d4 Author: Asanka Herath <asanka@chromium.org> Date: Thu Apr 05 20:46:50 2018 Make FilenameUtilTest.GenerateSafeFileName independent of OS config. This test could be sensitive to platform configuration since it relied on generating a filename extension based on a MIME type. In particular, if the platform configration associated anything other than .htm on text/html on Windows the test would fail. (Same for .html on Posix). This change refactors the test for readability, and removes its dependence on local configuration. Bug: 828954 Change-Id: Iad2b838e0f044ccdbf7eb2caf2a08d65a4dab857 Reviewed-on: https://chromium-review.googlesource.com/996354 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#548548} [modify] https://crrev.com/090f40e09d091ba08659ba9f1ad0111f90e000d4/net/base/filename_util_unittest.cc
,
Apr 5 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by zmin@chromium.org
, Apr 4 2018Status: Assigned (was: Untriaged)