New issue
Advanced search Search tips

Issue 828949 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Don't fire CanMakePaymentEvent for supported_origins:*

Project Member Reported by rouslan@chromium.org, Apr 4 2018

Issue description

Don't fire CanMakePaymentEvent for supported_origins:*.
 
Cc: rouslan@chromium.org
Owner: gogerald@chromium.org
Thank you for volunteering to take this on, Ganggui.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2

commit a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2
Author: gogerald <gogerald@google.com>
Date: Tue Apr 10 00:33:47 2018

[Payments] Do not send CanMakePayment events to not explicitly verified payment apps.

like have not been listed as default application or supported origins in the payment method manifest.

Bug:  828949 
Change-Id: If4b0d79681ed30112a18a39997a67f6d2723d3d3
Reviewed-on: https://chromium-review.googlesource.com/998796
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549347}
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndBasicCardWithModifiersTest.java
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/chrome/browser/payments/manifest_verifier_browsertest.cc
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/components/payments/content/manifest_verifier.cc
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/components/payments/content/service_worker_payment_instrument.cc
[modify] https://crrev.com/a74f9dec6fbf9c9b761fec564db5404b7fe8b8b2/content/public/browser/stored_payment_app.h

Status: Fixed (was: Assigned)

Sign in to add a comment