New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 828890 link

Starred by 3 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Sep 27
Cc:
blundell@chromium.org
alemate@chromium.org
ultrotter@chromium.org
█ bauerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Delete legacy Supervised User creation code

Project Member Reported by treib@chromium.org, Apr 4 2018 
Legacy Supervised User creation (features::kSupervisedUserCreation) has been disabled for a while, and in fact it doesn't actually work anymore because required server-side infrastructure isn't there anymore. It's time to get rid of the code.
Some care is required, since existing SUs should still be kept in a working state for now.

Comment 1 by treib@chromium.org, Apr 4 2018

Labels: -Pri-3 Pri-2
Owner: treib@chromium.org
Status: Started (was: Available)
Actually, I'll get started on this, since it's actively in my way in the context of  bug 825190 .
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a

commit 9bc50fd17179b8b0a2dffc1e82dc8fc20442816a
Author: Marc Treib <treib@chromium.org>
Date: Mon Apr 16 10:58:17 2018

Cleanup: Remove legacy Supervised User creation code, part 1

This removes features::kSupervisedUserCreation and a bunch of now-dead code.
There's lots more, but this is plenty for one CL.

Bug:  828890 
Change-Id: I2793654046a71104b153e5808fe97a2c4151ad12
Reviewed-on: https://chromium-review.googlesource.com/996072
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550961}
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/BUILD.gn
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility.h
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.h
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_service_browsertest.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/sync/test/integration/single_client_supervised_user_settings_sync_test.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/signin_create_profile_handler.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/common/chrome_features.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/common/chrome_features.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/test/BUILD.gn
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/test/data/webui/md_user_manager/user_manager_browsertest.js
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a

commit 9bc50fd17179b8b0a2dffc1e82dc8fc20442816a
Author: Marc Treib <treib@chromium.org>
Date: Mon Apr 16 10:58:17 2018

Cleanup: Remove legacy Supervised User creation code, part 1

This removes features::kSupervisedUserCreation and a bunch of now-dead code.
There's lots more, but this is plenty for one CL.

Bug:  828890 
Change-Id: I2793654046a71104b153e5808fe97a2c4151ad12
Reviewed-on: https://chromium-review.googlesource.com/996072
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550961}
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/BUILD.gn
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility.h
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.h
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/supervised_user/supervised_user_service_browsertest.cc
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/browser/sync/test/integration/single_client_supervised_user_settings_sync_test.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/signin_create_profile_handler.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/common/chrome_features.cc
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/common/chrome_features.h
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/test/BUILD.gn
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[delete] https://crrev.com/4c585c090be826a3b23673f6ec5435aaa6ecc6a3/chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js
[modify] https://crrev.com/9bc50fd17179b8b0a2dffc1e82dc8fc20442816a/chrome/test/data/webui/md_user_manager/user_manager_browsertest.js

Comment 4 by treib@chromium.org, May 3 2018

Labels: -Pri-2 Pri-3
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b10b51c74376ddabe8571f6c05829867710dd2

commit 98b10b51c74376ddabe8571f6c05829867710dd2
Author: Marc Treib <treib@chromium.org>
Date: Tue May 08 12:22:04 2018

MD User Manager: Remove Supervised User creation logic

Supervised Users are deprecated, and creation has been disabled for a
while. Time to get rid of the code.

Bug:  828890 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib95d138a5bdfa8fa150c99c1f85b8d2688ee3a27
Reviewed-on: https://chromium-review.googlesource.com/1029952
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556766}
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/app/generated_resources.grd
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/browser_resources.grd
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/resources/md_user_manager/BUILD.gn
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/resources/md_user_manager/create_profile.js
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/resources/md_user_manager/import_supervised_user.html
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/resources/md_user_manager/import_supervised_user.js
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/resources/md_user_manager/profile_browser_proxy.js
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/resources/md_user_manager/supervised_user_create_confirm.js
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/resources/md_user_manager/supervised_user_learn_more.html
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/resources/md_user_manager/supervised_user_learn_more.js
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/resources/md_user_manager/user_manager_pages.html
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/ui/webui/signin/md_user_manager_ui.h
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/ui/webui/signin/signin_create_profile_handler.h
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.h
[delete] https://crrev.com/73cedc1c0e054ac516f0130e81e8e34bdd17aae6/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/test/BUILD.gn
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[modify] https://crrev.com/98b10b51c74376ddabe8571f6c05829867710dd2/chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js
Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6066fa1754d612a5d29056e4543d462b76958eda

commit 6066fa1754d612a5d29056e4543d462b76958eda
Author: Marc Treib <treib@chromium.org>
Date: Mon May 14 11:18:51 2018

Cleanup: Delete unused supervised_user_test_base.h/cc

https://crrev.com/c/996072 removed the files from the build, but failed
to actually delete them.

Bug:  828890 
Change-Id: Ic3adda0fcf5bf051bf7e427018d4732ea2c98c07
Reviewed-on: https://chromium-review.googlesource.com/1057108
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558258}
[delete] https://crrev.com/bc834db47871842b7961247dff3cce0dd9b358dd/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[delete] https://crrev.com/bc834db47871842b7961247dff3cce0dd9b358dd/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/921271644f9764c972979c1823d69e7931c6cb5e

commit 921271644f9764c972979c1823d69e7931c6cb5e
Author: Marc Treib <treib@chromium.org>
Date: Mon Aug 27 14:20:03 2018

Remove supervised_user_id param from ProfileManager's Create methods

Supervised user creation has been gone for a long time, so these aren't
necessary anymore, and were never supplied (outside of some tests).

TBRing a whole bunch of trivial call site updates (i.e. not passing an
empty string as supervised_user_id).
TBR=jochen

Bug:  828890 
Change-Id: I45bb13111960b5c8b39a13b8368df1749fcfaa6d
Reviewed-on: https://chromium-review.googlesource.com/1188570
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586253}
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/app_controller_mac_browsertest.mm
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/chromeos/lock_screen_apps/lock_screen_profile_creator_impl.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/notifications/system_notification_helper.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/profiles/profile_list_desktop_browsertest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/profiles/profile_manager.h
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/profiles/profile_manager_browsertest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/app_list/test/chrome_app_list_test_support.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/bookmarks/bookmark_browsertest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/settings_window_manager_browsertest_chromeos.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/webui/profile_helper.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/webui/profile_helper_browsertest.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
[modify] https://crrev.com/921271644f9764c972979c1823d69e7931c6cb5e/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1

commit bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1
Author: Marc Treib <treib@chromium.org>
Date: Thu Sep 20 06:33:45 2018

Delete ChromeOS Supervised User creation UI

Supervised users have been gone for a long time.

Bug:  828890 
Change-Id: I18b12e49ac10c445eabc7151e7f3b7995b5fa24d
Reviewed-on: https://chromium-review.googlesource.com/1231314
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592700}
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/login/oobe_screen.h
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.cc
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.h
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.h
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/header_bar.html
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/header_bar.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/login_shared.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/md_header_bar.html
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/md_header_bar.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/md_login_screens.html
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/resources/chromeos/login/oobe_screens.html
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[delete] https://crrev.com/b720663b7731620e11daa212725117ae891e711c/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h
[modify] https://crrev.com/bbda3b6f19bc719c1ccefbd508d5bb2fb6d96bd1/ui/login/display_manager.js

Comment 9 by treib@chromium.org, Sep 20 

Summary so far: Removed 10 kLoC over 5 CLs. Not bad!

There's still SupervisedUserCreationPolicyHandler and prefs::kSupervisedUserCreationAllowed which don't do anything anymore, otherwise I think all the SU creation logic is gone.

Comment 10 by treib@chromium.org, Sep 20 

The policy was just removed in https://crrev.com/c/1224033.

Comment 11 by ultrotter@chromium.org, Sep 20

Cc: ultrotter@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1233577 removes IsLegacySupervised APIs and might be also relevant.
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58d996e62f721d13e7ccb2a947c10ad0d1148b9

commit a58d996e62f721d13e7ccb2a947c10ad0d1148b9
Author: Marc Treib <treib@chromium.org>
Date: Thu Sep 27 14:40:51 2018

Deprecate prefs::kSupervisedUserCreationAllowed

It was used to back a policy which was removed in
https://crrev.com/c/1224033, and supervised user creation itself has
been gone for way longer.

Bug:  828890 
Change-Id: I3a764e88f72599799263d1dc141d88e5e8b85a91
Reviewed-on: https://chromium-review.googlesource.com/1245708
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594715}
[modify] https://crrev.com/a58d996e62f721d13e7ccb2a947c10ad0d1148b9/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/a58d996e62f721d13e7ccb2a947c10ad0d1148b9/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/a58d996e62f721d13e7ccb2a947c10ad0d1148b9/chrome/common/pref_names.cc
[modify] https://crrev.com/a58d996e62f721d13e7ccb2a947c10ad0d1148b9/chrome/common/pref_names.h

Comment 13 by treib@chromium.org, Sep 27

Status: Fixed (was: Started)
I think this is all done now.
There is still SU-related code than can be removed or simplified (e.g. merging ChildAccountService into SupervisedUserService, or at least making their interplay simpler), but I think all the creation code is gone now.
►

Sign in to add a comment