New issue
Advanced search Search tips

Issue 828858 link

Starred by 2 users
Status: Assigned
Owner:
nzolghadr@chromium.org
Cc:
hu...@vewd.com
smcgruer@chromium.org
nzolghadr@chromium.org
robertma@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Implement testdriver.send_keys()

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Apr 4 2018 
WPT import https://crrev.com/c/995552 introduced new failures in external/wpt/infrastructure:

List of new failures:
[ Mac-mac10.12 ] external/wpt/infrastructure/testdriver/send_keys.html new failing tests: https://crrev.com/c/995552/4/third_party/WebKit/LayoutTests/platform/mac-mac10.12/external/wpt/infrastructure/testdriver/send_keys-expected.txt
[ Win ] external/wpt/infrastructure/testdriver/send_keys.html new failing tests: https://crrev.com/c/995552/4/third_party/WebKit/LayoutTests/platform/win/external/wpt/infrastructure/testdriver/send_keys-expected.txt

This import contains upstream changes from 6e2b4a77cb3d321b5d8a91bdbe4bbf8a0d777781 to 162e9dda47d694596620b69c5fb23cc7f0f87126:
Document useful arguments for `wpt run chrome` (#10238): https://github.com/w3c/web-platform-tests/commit/162e9dda47d694596620b69c5fb23cc7f0f87126
Correct reference to certificate file: https://github.com/w3c/web-platform-tests/commit/2b3f9012767698e957214631bbe710cb25ee8b26
Fix a typo in wpt/css/css-text-decor/text-emphasis-style-001.html: https://github.com/w3c/web-platform-tests/commit/c218fe33f47ca555d303dedeb117c205dc2a19a1
[Mojo Blob URLs] Resolve navigation blob URLs in blink.: https://github.com/w3c/web-platform-tests/commit/992147614f6cdd4fcb8b03e19c9af25cacacd192
Throw IdlHarnessError outside try: https://github.com/w3c/web-platform-tests/commit/81e900a6b04e9ba9bd07a478e2b0d349c02646c6
Updated filter-effects IDL file (#9884): https://github.com/w3c/web-platform-tests/commit/2bbb6b41d8804b0e9097a7723835409a67f602c6
Automated Keyboard Input (#10113): https://github.com/w3c/web-platform-tests/commit/8f93a78175a1c98e6d36bd8293ff5525edd0da91 [affecting this directory]
Updated ServiceWorker IDL file (#9886): https://github.com/w3c/web-platform-tests/commit/51b2242a8a064a83f1a993036a3f29848b933991
Merge pull request #9373 from w3c/user/frremy/contribute-css-fonts-4-tests: https://github.com/w3c/web-platform-tests/commit/00308147d33bdd04344e2308036e30c957b64915
Correct serialization of overflow: https://github.com/w3c/web-platform-tests/commit/09329e8bb6498a74cc8c054a263b2698a72d2f8e
Rewrite CSSOM index tests: https://github.com/w3c/web-platform-tests/commit/d30e62092787a340b4cfbeb0434a75e15028f69d
Fixed some duplicate test names: https://github.com/w3c/web-platform-tests/commit/2b27f602ab1417d3da743b12838c0af66f80f026
Remove fallback to linked font in installed-font test cases: https://github.com/w3c/web-platform-tests/commit/69f9347ad69c4a7b65e2b4d650eed2c975b30315
Fixed lint issues: https://github.com/w3c/web-platform-tests/commit/98b90adca4422a8f7f6d6056c298867fb879ceb7
Addressed @drott's feedback: https://github.com/w3c/web-platform-tests/commit/50b514678cb9262ba396ef959ff449d46a8fbfe6
Fixed incorrect calc() tests -- values should be clamped not rejected: https://github.com/w3c/web-platform-tests/commit/4f26743222cc18205e9aad7ce1155d5025fd5ee9
Added missing element: https://github.com/w3c/web-platform-tests/commit/d4154804b571d6ea006b0f1cf236f37480c111b2
More linting fixup: https://github.com/w3c/web-platform-tests/commit/8fb7e29e39f33757ae3385a230bbbd04f5631d30
Address Sergey's feedback (part 2): https://github.com/w3c/web-platform-tests/commit/33fbebf87b195281ce76c619404402e7e4afc929
Address Sergey's feedback (part 1): https://github.com/w3c/web-platform-tests/commit/be8a6942017702186f50792c2240c5f94ae48b96
[css-fonts-4] Contribute Microsoft tests for Font Variations: https://github.com/w3c/web-platform-tests/commit/84b8558cbf302be92b96b0b86bd1525481df01dc

Comment 1 by foolip@chromium.org, Apr 4 2018

Owner: kereliuk@chromium.org
Status: Assigned (was: Untriaged)
Summary: Implement testdriver.send_keys() (was: [WPT] New failures introduced in external/wpt/infrastructure by import https://crrev.com/c/995552)
Original title was "[WPT] New failures introduced in external/wpt/infrastructure by import https://crrev.com/c/995552"

This came from https://github.com/w3c/web-platform-tests/pull/10113.

kereliuk@, can you add the requisite bits in Chromium, or assign it to someone who can? It should presumably be implemented using eventSender?

Comment 2 by kereliuk@chromium.org, Apr 19 2018

Cc: hu...@vewd.com

Comment 3 by kereliuk@chromium.org, Jul 24

Cc: nzolghadr@chromium.org
Navid, are you able to take this or delegate it? I think it should be fairly easy and can use GPUBenchmarking after adding a mojo interface.

Comment 4 by nzolghadr@chromium.org, Jul 24

Owner: nzolghadr@chromium.org
To be more specific we need to add this function here in the vendor file:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testdriver-vendor.js?q=testdriver-vendor.js&sq=package:chromium&dr

Comment 5 by foolip@chromium.org, Aug 27 

This came up in https://chromium-review.googlesource.com/c/chromium/src/+/1168267/1 today. I think it should probably be implemented using eventSender.keyDown/keyUp.

Comment 6 by nzolghadr@chromium.org, Aug 27 

Correct. If we were to short circuit that function in testdriver-vendor.js today that would be the way to do it.

Comment 7 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to Pri-2.
►

Sign in to add a comment