New issue
Advanced search Search tips

Issue 828847 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 828843
issue 920545



Sign in to add a comment

Migrate V8's layout test bots to swarming

Project Member Reported by machenb...@chromium.org, Apr 4 2018

Issue description

Tracker bug.
 
Components: Infra>Client>V8
Status: Available (was: Untriaged)
Blocking: 920545
Owner: machenb...@chromium.org
Status: Started (was: Available)

Comment 5 Deleted

Comment 6 Deleted

Comment 7 Deleted

Comment 8 by machenbach@google.com, Jan 16 (6 days ago)

Cc: -qyears...@chromium.org -robertma@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4047920ee30974494dfc37b41f0d93e328dd96b4

commit 4047920ee30974494dfc37b41f0d93e328dd96b4
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 17 09:56:50 2019

[V8] Prepare blink-downstream switch to swarming

This creates a new abstraction for determining ToT failures or failures
with --future flag. The shared code of these two methodologies is
shared now.

This also inlines a few constant configuration values and removes the
temporary timeout extension.

Bug:  828847 
Change-Id: I54db0eba674b83e4f062741fb39f59c2d2de5fde
Reviewed-on: https://chromium-review.googlesource.com/c/1411547
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>

[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/blink_web_tests_unexpected_error.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/README.recipes.md
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/blink_web_tests_interrupted.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aaaf13cd3c2acc3939273a3bccf1a78219e623f8

commit aaaf13cd3c2acc3939273a3bccf1a78219e623f8
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 17 10:16:50 2019

[V8] Switch blink-downstream to swarming

This switches BlinkTest to SwarmingIsolatedScriptTest. Since
blink_downstream doesn't implement any of the dynamic testing
configuration features of Chromium, we hard-code all required
configuration values.

Bug:  828847 
Change-Id: I10894a9c8fdfa24e1d97ee407aa364584a50a043
Reviewed-on: https://chromium-review.googlesource.com/c/1411548
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>

[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/blink_web_tests_unexpected_error.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/README.recipes.md
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/blink_web_tests_interrupted.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[delete] https://crrev.com/4047920ee30974494dfc37b41f0d93e328dd96b4/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/aaaf13cd3c2acc3939273a3bccf1a78219e623f8/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Comment 11 by machenbach@google.com, Jan 17 (6 days ago)

We're close to declaring victory. The linux release builder is green again and looks like it works as it should. We can add it back to lkgr.

The debug builder is broken as it uses 'release' to find the builds on swarming. Needs investigation.

We also should use lower FYI prio for all bots but the lkgr one. We should also maybe use different shard numbers on different bots, like chromium does.
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0abbe6081388569f1a8b19b8983e6bd699759175

commit 0abbe6081388569f1a8b19b8983e6bd699759175
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 17 13:49:10 2019

[V8] Use custom shards and priority on blink_downstream

TBR=sergiyb@chromium.org

Bug:  828847 
Change-Id: I854b74170b926f48349821c39d43fd439b6ceb33
Reviewed-on: https://chromium-review.googlesource.com/c/1416259
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/README.recipes.md
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/0abbe6081388569f1a8b19b8983e6bd699759175/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Comment 14 by machenbach@google.com, Jan 17 (5 days ago)

Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/344b86a933b0806ece24adfb4db91378ffff53f6

commit 344b86a933b0806ece24adfb4db91378ffff53f6
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jan 18 10:23:59 2019

[V8] Archive layout-test results on blink_downstream

This was omitted when migrating to swarming.

TBR=sergiyb@chromium.org

Bug:  828847 
Change-Id: I7d23a092c057a0bac909ff923c7cf823d197e9d9
Reviewed-on: https://chromium-review.googlesource.com/c/1420618
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/blink_web_tests_unexpected_error.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/README.recipes.md
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/blink_web_tests_interrupted.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/344b86a933b0806ece24adfb4db91378ffff53f6/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0013fff621ae5a32a7228accfcdef1c8482bc349

commit 0013fff621ae5a32a7228accfcdef1c8482bc349
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jan 18 12:30:23 2019

[test] Remove obsolete blink test skips

The tests were skipped due to problems with the previous test setup. Now the
setup is the same as in Chromium and those tests should pass.

NOTRY=true

Bug:  chromium:828847 
Change-Id: Ibfbb931031176add90a340ca79c71e89f05e3045
Reviewed-on: https://chromium-review.googlesource.com/c/1421318
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58918}
[modify] https://crrev.com/0013fff621ae5a32a7228accfcdef1c8482bc349/tools/blink_tests/TestExpectations

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c8f4a44bd50c4d484c56a30312d01526dfc896d8

commit c8f4a44bd50c4d484c56a30312d01526dfc896d8
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jan 18 19:40:58 2019

Run fewer instances of blink_downstream debug

Due to swarming, the builder is now much faster then before and doesn't require
two concurrent instances.

NOTRY=true

Bug:  chromium:828847 
Change-Id: Ife4e5dd83dcaeaf0e0f88426b07d130feecea9fe
Reviewed-on: https://chromium-review.googlesource.com/c/1421317
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/c8f4a44bd50c4d484c56a30312d01526dfc896d8/luci-scheduler.cfg

Sign in to add a comment