V8's layout test debug bot should run in trybot configuration. |
||
Issue descriptionThere's no point in running a full debug bot for catching v8 upstream issues. A trybot config that sets dcheck_always_on essentially sets DEBUG in V8, while keep Chromium a release builder. This should speed up the testing and make that bot more reliable, which is currently perma-red and super-slow: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20(dbg)
,
Apr 6 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/146e3c18686017d222ce23fbcbcf1903b764fec4 commit 146e3c18686017d222ce23fbcbcf1903b764fec4 Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Apr 06 11:04:23 2018 [build] Align all debug-specific options behind v8_debug gn arg This will allow setting v8_debug from within a Chromium release bot. Bug: chromium:828846 Change-Id: I714291feaa9ba90daba871ca9a12e6651bcd7dfa Reviewed-on: https://chromium-review.googlesource.com/999486 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52432} [modify] https://crrev.com/146e3c18686017d222ce23fbcbcf1903b764fec4/BUILD.gn
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ce8367fa4883b33a7654c55e609a442801907eb commit 9ce8367fa4883b33a7654c55e609a442801907eb Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Apr 06 18:22:07 2018 [build] Make V8's blink debug builder use v8-only debug Bug: 828846 Change-Id: I6c0fd0f3d148b5eb075e71f8523819e6d35e382a Reviewed-on: https://chromium-review.googlesource.com/999491 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#548863} [modify] https://crrev.com/9ce8367fa4883b33a7654c55e609a442801907eb/tools/mb/mb_config.pyl |
||
►
Sign in to add a comment |
||
Comment 1 by machenb...@chromium.org
, Apr 4 2018