New issue
Advanced search Search tips

Issue 828810 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::MHTMLParser::ParseArchive

Project Member Reported by ClusterFuzz, Apr 4 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5693076501430272

Fuzzer: attekett_surku_fuzzer
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000028
Crash State:
  blink::MHTMLParser::ParseArchive
  blink::MHTMLArchive::Create
  blink::ResourceFetcher::CreateArchive
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=547819:547841

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5693076501430272

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 4 2018

Components: Blink>Loader Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 4 2018

Labels: Test-Predator-Auto-Owner
Owner: dewittj@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/cbd393505608eae84929c78ea1249ee2cf8e9121 ([Offline Pages] Extract main-frame URL from mhtml when rendered.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Cc: dewittj@chromium.org
 Issue 829217  has been merged into this issue.
Project Member

Comment 5 by ClusterFuzz, Apr 5 2018

Labels: OS-Linux
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/650e9e8c589fb43f25bd44387f3b10247cd660e7

commit 650e9e8c589fb43f25bd44387f3b10247cd660e7
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Apr 05 19:49:27 2018

[Offline Pages] Fix null deref in MHTMLParser.

This was found by ClusterFuzz, see test case in bug.

Bug:  828810 
Change-Id: I68e3050023d2475917334c54b5d85b7d20565775
Reviewed-on: https://chromium-review.googlesource.com/995962
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548530}
[modify] https://crrev.com/650e9e8c589fb43f25bd44387f3b10247cd660e7/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp
[modify] https://crrev.com/650e9e8c589fb43f25bd44387f3b10247cd660e7/third_party/WebKit/Source/platform/mhtml/MHTMLParserTest.cpp

Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Apr 6 2018

ClusterFuzz has detected this issue as fixed in range 548528:548543.

Detailed report: https://clusterfuzz.com/testcase?key=5693076501430272

Fuzzer: attekett_surku_fuzzer
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000028
Crash State:
  blink::MHTMLParser::ParseArchive
  blink::MHTMLArchive::Create
  blink::ResourceFetcher::CreateArchive
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=547819:547841
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=548528:548543

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5693076501430272

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Apr 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5693076501430272 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment