New issue
Advanced search Search tips

Issue 828808 link

Starred by 4 users
Status: Fixed
Owner: ----
Closed: May 2018
Cc:
szager@chromium.org
pdr@chromium.org
ana...@yandex-team.ru
skobes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug

Blocking:
issue 823365



Sign in to add a comment

[root layer scrolls] Scroll corner not painted

Project Member Reported by bokan@chromium.org, Apr 4 2018 
Chrome Version       : 67.0.3381.0
OS Version: Linux|Windows
URLs (if applicable) : Any page with horizontal+vertical scrolling. e.g. https://www.google.ca/search?q=cats&oq=cats&aqs=chrome.0.69i59j69i60l3j69i65j0.591j0j7&sourceid=chrome&ie=UTF-8

What steps will reproduce the problem?
1. Shrink the window so both scrollbars appear

What is the expected result?
Scroll corner should be grey

What happens instead of that?
Scroll corner is white

This is a difference between root layer scrolling and the old path.
RLSenable.jpg
933 KB View Download
RLSdisable.jpg
934 KB View Download

Comment 1 by skobes@chromium.org, Apr 17 2018

Blocking: 823365
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1ce7b951c1805995d522ce5a81020b8aae9edd

commit 6c1ce7b951c1805995d522ce5a81020b8aae9edd
Author: Rob Buis <rbuis@igalia.com>
Date: Thu May 17 17:06:34 2018

Paint scroll corner using ScrollbarTheme

Paint scroll corner using ScrollbarTheme for all scrollable areas. Note that we always
did that for the main frame, but RLS changes broke this.

Bug:  828808 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib6270cd06ccf6b19db692a2d16ee21feba48f45a
Reviewed-on: https://chromium-review.googlesource.com/1042573
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#559577}
[add] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/WebKit/LayoutTests/platform/linux/scrollbars/scrollbar-corner-colors-expected.png
[add] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/scrollbars/scrollbar-corner-colors-expected.png
[add] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/WebKit/LayoutTests/platform/mac/scrollbars/scrollbar-corner-colors-expected.png
[add] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/scrollbar-corner-colors-expected.png
[add] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/WebKit/LayoutTests/platform/win/scrollbars/scrollbar-corner-colors-expected.png
[add] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/WebKit/LayoutTests/scrollbars/scrollbar-corner-colors.html
[modify] https://crrev.com/6c1ce7b951c1805995d522ce5a81020b8aae9edd/third_party/blink/renderer/core/paint/scrollable_area_painter.cc

Comment 3 by rb...@igalia.com, May 27 2018

Status: Fixed (was: Available)
This should be fixed now.
►

Sign in to add a comment