New issue
Advanced search Search tips

Issue 828793 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 799030



Sign in to add a comment

Run external/wpt/webrtc/ tests with Unified Plan

Project Member Reported by hbos@chromium.org, Apr 4 2018

Issue description

This requires overriding the default SDP semantics with a new flag and adding a VirtualTestSuite to run it as virtual/.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280

commit 72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280
Author: Henrik Boström <hbos@chromium.org>
Date: Thu Apr 12 14:33:36 2018

Running virtual external/wpt/webrtc/ with Unified Plan.

This adds RuntimeEnabled feature RTCUnifiedPlanByDefault (off by
default even in LayoutTests) which overrides the default SDP semantics
of RTCPeerConnection, and adds running external/wpt/webrtc/* as a
virtual test suite with this flag enabled.

The tests can be run as:
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/

The -expected.txt files are identical to the non-virtual versions.
The only problem introduced with Unified Plan is that the following
test times out:
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/
    RTCPeerConnection-setRemoteDescription-tracks.https.html
  Bug filed:  https://crbug.com/828866 

And unlike external/wpt/webrtc/
    RTCPeerConnection-setLocalDescription-answer.html,
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/
    RTCPeerConnection-setLocalDescription-answer.html
does not fail against the -expected.txt file.

Bug:  828793 ,  828866 
Change-Id: I51d86fc5a0388ae1d8bf5f8497f31795d205d5d2
Reviewed-on: https://chromium-review.googlesource.com/995278
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550190}
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/README.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCCertificate-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCConfiguration-bundlePolicy-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCConfiguration-iceServers-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-addTrack.https-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-createOffer-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-ontrack.https-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https-expected.txt
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 3 by hbos@chromium.org, Apr 12 2018

Status: Verified (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280

commit 72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280
Author: Henrik Boström <hbos@chromium.org>
Date: Thu Apr 12 14:33:36 2018

Running virtual external/wpt/webrtc/ with Unified Plan.

This adds RuntimeEnabled feature RTCUnifiedPlanByDefault (off by
default even in LayoutTests) which overrides the default SDP semantics
of RTCPeerConnection, and adds running external/wpt/webrtc/* as a
virtual test suite with this flag enabled.

The tests can be run as:
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/

The -expected.txt files are identical to the non-virtual versions.
The only problem introduced with Unified Plan is that the following
test times out:
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/
    RTCPeerConnection-setRemoteDescription-tracks.https.html
  Bug filed:  https://crbug.com/828866 

And unlike external/wpt/webrtc/
    RTCPeerConnection-setLocalDescription-answer.html,
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/
    RTCPeerConnection-setLocalDescription-answer.html
does not fail against the -expected.txt file.

Bug:  828793 ,  828866 
Change-Id: I51d86fc5a0388ae1d8bf5f8497f31795d205d5d2
Reviewed-on: https://chromium-review.googlesource.com/995278
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550190}
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/README.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCCertificate-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCConfiguration-bundlePolicy-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCConfiguration-iceServers-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-addTrack.https-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-createOffer-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-ontrack.https-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https-expected.txt
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/72b2a8b60167ba05092a5ce9fcfa0ae2d48d3280/third_party/blink/renderer/platform/runtime_enabled_features.json5

Sign in to add a comment