New issue
Advanced search Search tips

Issue 828778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Pinpoint job builds are failing for older CLs

Project Member Reported by leszeks@chromium.org, Apr 4 2018

Issue description

Pinpoint job builds appear to be failing for older CLs that do not have the bot build config checked in.

E.g. https://pinpoint-dot-chromeperf.appspot.com/job/14cf8230c40000, https://ci.chromium.org/buildbot/tryserver.chromium.perf/Android%20Compile%20Perf/31
 

Comment 1 by st...@chromium.org, Apr 4 2018

Cc: dtu@chromium.org simonhatch@chromium.org
Components: -Tools>Test>FindIt Speed>Bisection
Pass over to Perf Pinpoint team.

Comment 2 by dtu@chromium.org, Apr 4 2018

There are two issues related to the rename of the perf builders (issue 792780):

* We can no longer look up old builds, since they are keyed by builder name. I've deployed a temporary hack that checks both the old and new builder names.
  Longer term: I'm also working on a migration script to convert all the database entries to the new names. Unfortunately, the DB format wasn't designed to handle migrations gracefully, so it may be a few days.

* We can't build/backfill any commits before the new builder names were added to mb_config.pyl, since that's in the Chromium repository. Since we can look up and use old builds, this is only a problem if someone tries to bisect across the migration range, where there were a handful of failed builds on the perf waterfall.
Cc: machenb...@chromium.org
Owner: dtu@chromium.org
Is the temporary hack in place now? That is, should things be working now?

Comment 4 by dtu@chromium.org, Apr 5 2018

Yes, things should mostly be working. Data migration is also underway.

Comment 5 by dtu@chromium.org, May 1 2018

Status: Fixed (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/422da60cd68bbfef29b4d8e9264e3d1948ec9001

commit 422da60cd68bbfef29b4d8e9264e3d1948ec9001
Author: Dave Tu <dtu@chromium.org>
Date: Thu Jul 19 16:36:54 2018

[pinpoint] Clean up deprecated isolate code.

We've already removed the old non-conforming
Isolate entities in the data migration for #4534.

Bug:  chromium:828778 
Change-Id: I7237f842e29d36837ea2b648715315af791ce32c
Reviewed-on: https://chromium-review.googlesource.com/1142742
Commit-Queue: David Tu <dtu@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/422da60cd68bbfef29b4d8e9264e3d1948ec9001/dashboard/dashboard/pinpoint/models/isolate.py
[modify] https://crrev.com/422da60cd68bbfef29b4d8e9264e3d1948ec9001/dashboard/dashboard/pinpoint/models/isolate_test.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e498d8b1d30cb9e3fa7e7065f567ebafae5d1a7

commit 7e498d8b1d30cb9e3fa7e7065f567ebafae5d1a7
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jul 19 21:09:45 2018

Roll src/third_party/catapult 2ec2b508e610..26a1ccee228a (4 commits)

https://chromium.googlesource.com/catapult.git/+log/2ec2b508e610..26a1ccee228a


git log 2ec2b508e610..26a1ccee228a --date=short --no-merges --format='%ad %ae %s'
2018-07-19 simonhatch@chromium.org Dashboard - Add required field to body when creating bugs.
2018-07-19 dtu@chromium.org [pinpoint] Clean up deprecated isolate code.
2018-07-19 wangge@google.com Added script to generate milestone version release date table
2018-07-19 nednguyen@google.com Memorize the ts_proxy_server's traffic settings and only set them when they


Created with:
  gclient setdep -r src/third_party/catapult@26a1ccee228a

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:865147 , chromium:828778 , chromium:863390 ,chromium:861534
TBR=sullivan@chromium.org

Change-Id: I75a636b6d6ce1cabb7b356876f22808022a4eca0
Reviewed-on: https://chromium-review.googlesource.com/1143986
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576625}
[modify] https://crrev.com/7e498d8b1d30cb9e3fa7e7065f567ebafae5d1a7/DEPS

Sign in to add a comment