Adaptive Toolbar: Incognito tab count is seen at the left top corner on changing the device orientation from landscape to portrait. |
|||||||||
Issue descriptionApp Version: 67.0.3388.0 canary iOS Version: 10.3.3, 11.4 beta Device: iPhone Prerequisite: 1- Enable ‘UI Refresh Phase 1 (#ui-refresh-phase-1) flag from chrome flags 2. Open few incognito tabs Steps to reproduce: 1. Launch chrome in landscape mode. 2. Tap on fake omnibox. 3. Change the device orientation to portrait mode. 4. Tap on Cancel. 5. Tap on Menu > Tap on New Incognito tab. Observed results: Incognito opened tab count is shown at left top corner. Expected results: Incognito count should not be displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build :M65, NA (New Feature) Bug reproducible on the current beta channel build :M66, NA (New Feature) Video : https://drive.google.com/file/d/1KniduRmKtGnivkXyC9AfB9V2OscYY1gX/view?usp=sharing Image : https://drive.google.com/file/d/1GMmGohwFQLU81Z2fiFkYh1VwWAYQ-ffs/view?usp=sharing
,
Apr 5 2018
,
Apr 5 2018
,
Apr 6 2018
,
Apr 16 2018
I wasn't able to reproduce, I tried on iPhone 8+ iOS 11.3. Is there something else I am missing? Should the app be killed/backgrounded?
,
Apr 17 2018
able to repro the issue with the below steps. Steps to repro : 1. launch chrome in portrait mode. 2. Tap on Menu > Incognito tab 3. Change the device orientation to landscape mode. 4. Tap on Menu > New tab 5. Tap on the fake omnibox. 6. Send the app to background 7. Relaunch chrome in Portrait mode. 8. Tap on Cancel beside the omnibox. 9. Tap on Menu > Incognito tab Observed Result : Incognito opened tab count is shown at left top corner. Video : https://drive.google.com/file/d/1XyxPpsY5UjQajXcBe9j7wMD1r4PANEAy/view?usp=sharing
,
Apr 17 2018
Great! Thanks for your help. I am able to reproduce even without step 6. Please note that on newer version (today's or tomorrow's canary), the number of opened tab count is shown in the top right corner (not top left).
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75cb62133ff9fcb020cc76c41e10cf35b1aefcbc commit 75cb62133ff9fcb020cc76c41e10cf35b1aefcbc Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 17 14:42:28 2018 Update "hidden" property in the toolbar buttons This CL update the hidden property of the toolbar buttons based on the current size class each time the button checks if it should be displayed in the current size class, even if the result is the same as the current hidden property. Bug: 828767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iec39f2bb5ca80c78d7a04e0225a9f048c09d0f28 Reviewed-on: https://chromium-review.googlesource.com/1013527 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551325} [modify] https://crrev.com/75cb62133ff9fcb020cc76c41e10cf35b1aefcbc/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm
,
Apr 17 2018
,
Apr 24 2018
Verified in 68.0.3405.0 Canary, iPhone X iOS 11.4 beta 2, iPhone 7 iOS11.4 beta Looks good
,
Apr 25 2018
The NextAction date has arrived: 2018-04-25
,
Apr 25 2018
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe0e8552354de80dc6dc33936b90faccaa8a903 commit dfe0e8552354de80dc6dc33936b90faccaa8a903 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Jul 10 14:32:43 2018 Update TabGridToolbarButton's label This CL changes the label of the TabGridToolbarButton to use a UILabel instead of its title label. The title label isn't hidden properly when the button is hidden. Bug: 828767 , 860712 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I30f091416b50eff035716bbfd6719b26c8308085 Reviewed-on: https://chromium-review.googlesource.com/1131180 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#573716} [modify] https://crrev.com/dfe0e8552354de80dc6dc33936b90faccaa8a903/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/dfe0e8552354de80dc6dc33936b90faccaa8a903/ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.mm |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by subhashi...@chromium.org
, Apr 4 2018Labels: Restrict-View-Google
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Summary: Adaptive Toolbar: Incognito tab count is seen at the left top corner on changing the device orientation from landscape to portrait. (was: Incognito tab count is seen at the left top corner on changing the device orientation from landscape to portrait.)