New issue
Advanced search Search tips

Issue 828764 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Milo should show steps that were executed before the task has been KILLED

Project Member Reported by serg...@chromium.org, Apr 4 2018

Issue description

See: https://luci-milo.appspot.com/swarming/task/3ca8cec374c58f10. The build has actually mostly executed and even triggered child builds. Would be nice to be able to see the steps that were executed and their logs.
 
Interestingly, the steps are visible from the following link: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20builder/448.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a664d557032fd3fbf506bccdc088095bddbd854a

commit a664d557032fd3fbf506bccdc088095bddbd854a
Author: Ryan Tseng <hinoka@google.com>
Date: Thu Apr 05 00:19:14 2018

[milo] Color in cancelled builds

Also add in "KILLED" as a synonym to the "CANCELLED" swarming state.
They mean the same thing.

Bug:  828764 
Change-Id: Ie89efbc4ef515ce0c8f9212bf6d7d4c8504f98c4
Reviewed-on: https://chromium-review.googlesource.com/996766
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/a664d557032fd3fbf506bccdc088095bddbd854a/milo/buildsource/swarming/build.go
[modify] https://crrev.com/a664d557032fd3fbf506bccdc088095bddbd854a/milo/frontend/appengine/static/buildbot/css/default.css
[modify] https://crrev.com/a664d557032fd3fbf506bccdc088095bddbd854a/milo/frontend/appengine/templates/pages/build.html

Comment 3 by no...@chromium.org, Apr 6 2018

Status: Fixed (was: Untriaged)
seems fixed now

FWIW the code that was fixed should not exist. We should use buildbucket status instead.

Sign in to add a comment