New issue
Advanced search Search tips

Issue 828760 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 770175



Sign in to add a comment

DCHECK on password autofill on oneplusstore.in

Project Member Reported by vabr@chromium.org, Apr 4 2018

Issue description

Chrome Version       : 67.0.3389.0
OS Version: OS X 10.13.3
URLs (if applicable) : https://oneplusstore.in/account/sign-in

What steps will reproduce the problem?
1. Go to https://oneplusstore.in/account/sign-in
2. Type in test@gmail.com as a username and some password.
3. Click the key icon in the right-hand end of the URL bar, save the credential.
4. Reload the page

What is the expected result?
The password gets filled.

What happens instead of that?
The
  DCHECK(frame_->View() == this);
in LocalFrameView::ScheduleRelayoutOfSubtree seems to fire (stack trace below).

Note: When running this on Canary without DCHECKs enabled, the password field does not end up autofilled, only the username.

[88829:775:0404/110512.414540:FATAL:LocalFrameView.cpp(2324)] Check failed: false. 
0   libbase.dylib                       0x0000000104c1544c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   libbase.dylib                       0x0000000104c4081f logging::LogMessage::~LogMessage() + 223
2   libblink_core.dylib                 0x0000000113f8162d blink::LocalFrameView::ScheduleRelayoutOfSubtree(blink::LayoutObject*) + 397
3   libblink_core.dylib                 0x000000011440d9d8 blink::LayoutObject::MarkContainerChainForLayout(bool, blink::SubtreeLayoutScope*) + 664
4   libblink_core.dylib                 0x0000000113c933f7 blink::LayoutObject::SetNeedsLayout(char const*, blink::MarkingBehavior, blink::SubtreeLayoutScope*) + 199
5   libblink_core.dylib                 0x00000001143e8bb6 blink::LayoutImage::InvalidatePaintAndMarkForLayoutIfNeeded(blink::ImageResourceObserver::CanDeferInvalidation) + 502
6   libblink_core.dylib                 0x00000001143e899c blink::LayoutImage::ImageChanged(void*, blink::ImageResourceObserver::CanDeferInvalidation, blink::IntRect const*) + 1020
7   libblink_core.dylib                 0x000000011441a090 blink::LayoutObject::ImageChanged(blink::ImageResourceContent*, blink::ImageResourceObserver::CanDeferInvalidation, blink::IntRect const*) + 224
8   libblink_core.dylib                 0x000000011460269d blink::ImageResourceContent::NotifyObservers(blink::ImageResourceContent::NotifyFinishOption, blink::ImageResourceObserver::CanDeferInvalidation, blink::IntRect const*) + 365
9   libblink_core.dylib                 0x000000011460348e blink::ImageResourceContent::UpdateImage(scoped_refptr<blink::SharedBuffer>, blink::ResourceStatus, blink::ImageResourceContent::UpdateImageOption, bool, bool) + 2158
10  libblink_core.dylib                 0x00000001145fdfbe blink::ImageResource::AppendData(char const*, unsigned long) + 254
11  libblink_platform.dylib             0x0000000116f75ed8 blink::ResourceLoader::DidReceiveData(char const*, int) + 168
12  libcontent.dylib                    0x000000010d9426ee content::WebURLLoaderImpl::Context::OnReceivedData(std::__1::unique_ptr<content::RequestPeer::ReceivedData, std::__1::default_delete<content::RequestPeer::ReceivedData> >) + 190
13  libcontent.dylib                    0x000000010d943200 content::WebURLLoaderImpl::RequestPeerImpl::OnReceivedData(std::__1::unique_ptr<content::RequestPeer::ReceivedData, std::__1::default_delete<content::RequestPeer::ReceivedData> >) + 128
14  libcontent.dylib                    0x000000010d93b44c content::URLResponseBodyConsumer::OnReadable(unsigned int) + 604
15  libcontent.dylib                    0x000000010d93a4f6 content::URLLoaderClientImpl::OnStartLoadingResponseBody(mojo::ScopedHandleBase<mojo::DataPipeConsumerHandle>) + 534
16  libcontent.dylib                    0x000000010cc273fe content::ThrottlingURLLoader::OnStartLoadingResponseBody(mojo::ScopedHandleBase<mojo::DataPipeConsumerHandle>) + 206
17  libcontent.dylib                    0x000000010cb70fca network::mojom::URLLoaderClientStubDispatch::Accept(network::mojom::URLLoaderClient*, mojo::Message*) + 2234
18  libbindings.dylib                   0x0000000105c8b936 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) + 950
19  libbindings.dylib                   0x0000000105c8b206 mojo::FilterChain::Accept(mojo::Message*) + 150
20  libbindings.dylib                   0x0000000105c8cd65 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) + 117
21  libbindings.dylib                   0x0000000105c939bc mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) + 1420
22  libbindings.dylib                   0x0000000105c92dc0 mojo::internal::MultiplexRouter::Accept(mojo::Message*) + 368
23  libbindings.dylib                   0x0000000105c8b206 mojo::FilterChain::Accept(mojo::Message*) + 150
24  libbindings.dylib                   0x0000000105c85e33 mojo::Connector::ReadSingleMessage(unsigned int*) + 419
25  libbindings.dylib                   0x0000000105c86881 mojo::Connector::ReadAllAvailableMessages() + 97
26  libbindings.dylib                   0x0000000105c86739 mojo::Connector::OnHandleReadyInternal(unsigned int) + 137
27  libbindings.dylib                   0x0000000105c86fd7 mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) + 103
28  libmojo_public_system_cpp.dylib     0x0000000105cfcecc mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) + 332
29  libmojo_public_system_cpp.dylib     0x0000000105cfd3f1 void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&&&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) + 193
30  libbase.dylib                       0x0000000104c15dc4 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 260
31  libblink_platform.dylib             0x0000000116fb3316 blink::scheduler::internal::ThreadControllerImpl::DoWork(blink::scheduler::internal::SequencedTaskSource::WorkType) + 918
32  libblink_platform.dylib             0x0000000116fb516b base::internal::Invoker<base::internal::BindState<void (blink::scheduler::internal::ThreadControllerImpl::*)(blink::scheduler::internal::SequencedTaskSource::WorkType), base::WeakPtr<blink::scheduler::internal::ThreadControllerImpl>, blink::scheduler::internal::SequencedTaskSource::WorkType>, void ()>::Run(base::internal::BindStateBase*) + 187
33  libbase.dylib                       0x0000000104c15dc4 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 260
34  libbase.dylib                       0x0000000104c59489 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 121
35  libbase.dylib                       0x0000000104c5dea7 base::MessageLoop::RunTask(base::PendingTask*) + 599
36  libbase.dylib                       0x0000000104c5e26a base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 186
37  libbase.dylib                       0x0000000104c5e4dc base::MessageLoop::DoWork() + 572
38  libbase.dylib                       0x0000000104c6269a base::MessagePumpCFRunLoopBase::RunWork() + 42
39  libbase.dylib                       0x0000000104c4304a base::mac::CallWithEHFrame(void () block_pointer) + 10
40  libbase.dylib                       0x0000000104c61f7f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
41  CoreFoundation                      0x00007fff4e5dba21 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
42  CoreFoundation                      0x00007fff4e69326c __CFRunLoopDoSource0 + 108
43  CoreFoundation                      0x00007fff4e5beab0 __CFRunLoopDoSources0 + 208
44  CoreFoundation                      0x00007fff4e5bdf2d __CFRunLoopRun + 1293
45  CoreFoundation                      0x00007fff4e5bd787 CFRunLoopRunSpecific + 487
46  Foundation                          0x00007fff506a9c16 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
47  libbase.dylib                       0x0000000104c62efe base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 142
48  libbase.dylib                       0x0000000104c619ce base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110
49  libbase.dylib                       0x0000000104c5d7c9 base::MessageLoop::Run(bool) + 169
50  libbase.dylib                       0x0000000104c9f379 base::RunLoop::Run() + 249
51  libcontent.dylib                    0x000000010da0db2c content::RendererMain(content::MainFunctionParams const&) + 1564
52  libcontent.dylib                    0x000000010dbef24a content::ContentMainRunnerImpl::Run() + 554
53  libembedder.dylib                   0x0000000104b5d806 service_manager::Main(service_manager::MainParams const&) + 2470
54  libcontent.dylib                    0x000000010dbee644 content::ContentMain(content::ContentMainParams const&) + 68
55  libchrome_dll.dylib                 0x00000001062c6e33 ChromeMain + 179
56  Chromium Helper                     0x0000000102ede9ec main + 1788
57  libdyld.dylib                       0x00007fff75f6f115 start + 1



 

Comment 1 by vabr@chromium.org, Apr 4 2018

The "password not filled" part is due to a hidden password field (style="display: none; height: 0px; opacity: 0; position: absolute;"). That hidden field gets filled, while the visible one can only get filled on demand.

Comment 2 by ma...@chromium.org, May 1 2018

Components: UI>Browser>Autofill

Sign in to add a comment