New issue
Advanced search Search tips

Issue 828749 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

unittests for cros_vm and cros_run_vm_test

Project Member Reported by achuith@chromium.org, Apr 4 2018

Issue description

Need unittest coverage for cros_vm.py and cros_run_vm_test.py


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fe17d502c00b156e70d5bcabbfbccb22748882e8

commit fe17d502c00b156e70d5bcabbfbccb22748882e8
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu May 17 10:24:25 2018

cros_run_vm_test: Introduce Run()

* Move functionality of main into Run()
* Add --remote-cmd instead of using cros_vm's --cmd
* All options are now private members instead of being dealt with
ad-hoc.
* Move handling of --cmd and --host-cmd into RunTests
* Rename ProcessResult to OutputResults

BUG=chromium:828749
TEST=manual

Change-Id: I2765b812473eb54528c7195e5fb9c2174d6397ac
Reviewed-on: https://chromium-review.googlesource.com/1058109
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/fe17d502c00b156e70d5bcabbfbccb22748882e8/scripts/cros_run_vm_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/967fde3df89a8c5dc9946ce0d6045dc26785940e

commit 967fde3df89a8c5dc9946ce0d6045dc26785940e
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 17 12:17:52 2018

Roll src/third_party/chromite/ 84d0e6526..be1ac9516 (4 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/84d0e6526470..be1ac951607e

$ git log 84d0e6526..be1ac9516 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 yunlian Test ThinLTO on peach_pit
2018-05-16 dgarrett chromeos_config: Remove trybot_list.
2018-05-14 achuith cros_run_vm_test: Introduce Run()
2018-05-04 bmgordon cros_sdk_lib: Move chroot functions out of cros_build_lib

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None,chromium:None,chromium:828749,chromium:809634


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8d7668d4891451a613c52552f203a10c0dbc17f6
Reviewed-on: https://chromium-review.googlesource.com/1063991
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559498}
[modify] https://crrev.com/967fde3df89a8c5dc9946ce0d6045dc26785940e/DEPS

Test for sudo usage.
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
Components: Infra>Client>ChromeOS>Build

Sign in to add a comment