New issue
Advanced search Search tips

Issue 828748 link

Starred by 1 user
Status: Duplicate
Merged: issue 828746
Owner: ----
Closed: Apr 2018
Cc:
futhark@chromium.org
foolip@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NOTREACHED() in ComputedStyleUtils::ValueForFontStyle() hit in upcoming WPT css-fonts tests

Project Member Reported by raphael....@intel.com, Apr 4 2018 
https://github.com/w3c/web-platform-tests/pull/9373 is causing a NOTREACHED() to be reached in ComputedStyleUtils::ValueForFontStyle(), and it's blocking our WPT imports.

Specifically, the following 3 tests are failing when DCHECKs are enabled (see e.g. https://chromium-review.googlesource.com/c/chromium/src/+/994772): 
* external/wpt/css/css-fonts/variations/font-shorthand.html
* external/wpt/css/css-fonts/variations/font-style-interpolation.html
* external/wpt/css/css-fonts/variations/font-weight-lighter-bolder.html

The backtrace looks like this:
STDERR: [1:1:0403/224514.988034:FATAL:ComputedStyleUtils.cpp(759)] Check failed: false. 
STDERR: #0 0x0000034f87fc base::debug::StackTrace::StackTrace()
STDERR: #1 0x000003518c0b logging::LogMessage::~LogMessage()
STDERR: #2 0x0000051b80bd blink::ComputedStyleUtils::ValueForFontStyle()
STDERR: #3 0x00000503b505 blink::CSSComputedStyleDeclaration::GetPropertyCSSValue()
STDERR: #4 0x0000050701b0 blink::CSSStyleDeclaration::AnonymousNamedGetter()
STDERR: #5 0x000004d91902 blink::V8CSSStyleDeclaration::namedPropertyGetterCallback()
STDERR: #6 0x0000024ed3de v8::internal::PropertyCallbackArguments::BasicCallNamedGetterCallback()
STDERR: #7 0x0000024ed0e8 v8::internal::PropertyCallbackArguments::CallNamedGetter()
STDERR: #8 0x0000024ea0b0 v8::internal::__RT_impl_Runtime_LoadPropertyWithInterceptor()

Comment 1 by raphael....@intel.com, Apr 4 2018

Cc: foolip@chromium.org futhark@chromium.org
+foolip who's on ecosystem infra rotation today
+futhark for triaging
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4f1b38bb13e6a7dfb8f62eb36ff33495454d7ae

commit a4f1b38bb13e6a7dfb8f62eb36ff33495454d7ae
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Wed Apr 04 08:34:17 2018

Mark a few css-fonts tests as crashing

These are hitting a NOTREACHED() and blocking WPT imports after
https://github.com/w3c/web-platform-tests/pull/9373 landed upstream.

TBR=foolip

Bug:  828748 
Change-Id: I72ec5dbe80bd9f5e893a56380acd99aa62a91da0
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/995094
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#548006}
[modify] https://crrev.com/a4f1b38bb13e6a7dfb8f62eb36ff33495454d7ae/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by foolip@chromium.org, Apr 4 2018

Mergedinto: 828746
Status: Duplicate (was: Available)
I filed  issue 828746  and  issue 828747  since there are two NOTREACHED() involved, duping into the first of those.
►

Sign in to add a comment