NOTREACHED() in FontDescription::BolderWeight when for external/wpt/css/css-fonts/variations/font-weight-lighter-bolder.html |
||||
Issue descriptionThis line was reached when trying to import new changes from web-platform-tests: https://chromium-review.googlesource.com/c/chromium/src/+/993514 https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/60797/layout-test-results/results.html The failure is: STDERR: [1:1:0403/185325.511002:FATAL:FontDescription.cpp(134)] Check failed: false. STDERR: #0 0x0000034f6b6c base::debug::StackTrace::StackTrace() STDERR: #1 0x000003516f7b logging::LogMessage::~LogMessage() STDERR: #2 0x000004e39bc9 blink::FontDescription::BolderWeight() STDERR: #3 0x00000522730a blink::StyleBuilderConverterBase::ConvertFontWeight() STDERR: #4 0x0000051d4bb8 blink::CSSLonghand::FontWeight::ApplyValue() STDERR: #5 0x00000523b9d3 blink::StyleBuilder::ApplyProperty() STDERR: #6 0x000005233af9 blink::StyleBuilder::ApplyProperty() STDERR: #7 0x000005250299 blink::StyleResolver::ApplyProperties<>() STDERR: #8 0x00000524a129 blink::StyleResolver::ApplyMatchedProperties<>() STDERR: #9 0x00000524d0f8 blink::StyleResolver::ApplyMatchedStandardProperties() STDERR: #10 0x00000524852a blink::StyleResolver::ApplyMatchedPropertiesAndCustomPropertyAnimations() STDERR: #11 0x000005247fc8 blink::StyleResolver::StyleForElement() STDERR: #12 0x0000052f714a blink::Element::OriginalStyleForLayoutObject() STDERR: #13 0x0000052f6be4 blink::Element::StyleForLayoutObject() STDERR: #14 0x0000052f89ef blink::Element::RecalcStyleForReattach() STDERR: #15 0x00000527ca5f blink::ContainerNode::RecalcDescendantStylesForReattach() STDERR: #16 0x0000052f8b73 blink::Element::RecalcStyleForReattach() STDERR: #17 0x00000527ca5f blink::ContainerNode::RecalcDescendantStylesForReattach() STDERR: #18 0x0000052f8b73 blink::Element::RecalcStyleForReattach() STDERR: #19 0x00000527ca5f blink::ContainerNode::RecalcDescendantStylesForReattach() STDERR: #20 0x0000052f8b73 blink::Element::RecalcStyleForReattach() STDERR: #21 0x00000527ca5f blink::ContainerNode::RecalcDescendantStylesForReattach() STDERR: #22 0x0000052f7c99 blink::Element::RecalcOwnStyle() STDERR: #23 0x0000052f756b blink::Element::RecalcStyle() STDERR: #24 0x0000052a8842 blink::Document::UpdateStyle() STDERR: #25 0x0000052a3efc blink::Document::UpdateStyleAndLayoutTree() STDERR: #26 0x0000052a9d9f blink::Document::UpdateStyleAndLayoutTreeForNode() STDERR: #27 0x000005039609 blink::CSSComputedStyleDeclaration::GetPropertyCSSValue() STDERR: #28 0x00000506e490 blink::CSSStyleDeclaration::AnonymousNamedGetter() STDERR: #29 0x000004d8faa2 blink::V8CSSStyleDeclaration::namedPropertyGetterCallback() STDERR: #30 0x0000024ec8f4 v8::internal::PropertyCallbackArguments::BasicCallNamedGetterCallback() STDERR: #31 0x0000024ec5f8 v8::internal::PropertyCallbackArguments::CallNamedGetter() STDERR: #32 0x0000025bf78e v8::internal::(anonymous namespace)::GetPropertyWithInterceptorInternal() STDERR: #33 0x0000025b8a9b v8::internal::Object::GetProperty() STDERR: #34 0x0000024d38f7 v8::internal::LoadIC::Load() STDERR: #35 0x0000024e220a v8::internal::__RT_impl_Runtime_LoadIC_Miss() STDERR: #36 0x1f08fce04252 <unknown> The line in question: https://chromium.googlesource.com/chromium/src/+blame/d35f7c6107242ba8ef7df7335ba2eeda07e8da82/third_party/WebKit/Source/platform/fonts/FontDescription.cpp#134 The test has weight 901, so maybe that's the problem.
,
Apr 4 2018
,
Apr 5 2018
,
Apr 5 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df5ec60ee230d01cec162618440b37c48ea4c105 commit df5ec60ee230d01cec162618440b37c48ea4c105 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Apr 05 16:37:06 2018 Adjust weight ranges in FontDescription::Lighter/BolderWeight Since the (CSS) parser allows numeric weight values in the range [1, 1000], adjust the ranges in FontDescription::Lighter/BolderWeight to match that. Also factor in that the values can have fractions (by implicitly truncating them) and simplify the range check since there's now a set of adjacent intervals in practice. Bug: 828747 Change-Id: I5fe3405ca45ed8016530d995976e36a6ebbcf366 Reviewed-on: https://chromium-review.googlesource.com/995452 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#548448} [modify] https://crrev.com/df5ec60ee230d01cec162618440b37c48ea4c105/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/df5ec60ee230d01cec162618440b37c48ea4c105/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
,
Apr 6 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by foolip@chromium.org
, Apr 4 2018