New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828746 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 809938
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 809920



Sign in to add a comment

NOTREACHED() in ComputedStyleUtils::ValueForFontStyle for external/wpt/css/css-fonts/variations/font-shorthand.html

Project Member Reported by foolip@chromium.org, Apr 4 2018

Issue description

This line was reached when trying to import new changes from web-platform-tests:
https://chromium-review.googlesource.com/c/chromium/src/+/993514
https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/60797/layout-test-results/results.html

The failure is:

crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: [1:1:0403/185324.670118:FATAL:ComputedStyleUtils.cpp(759)] Check failed: false. 
STDERR: #0 0x0000034f6b6c base::debug::StackTrace::StackTrace()
STDERR: #1 0x000003516f7b logging::LogMessage::~LogMessage()
STDERR: #2 0x0000051b639d blink::ComputedStyleUtils::ValueForFontStyle()
STDERR: #3 0x0000050397e5 blink::CSSComputedStyleDeclaration::GetPropertyCSSValue()
STDERR: #4 0x00000506e490 blink::CSSStyleDeclaration::AnonymousNamedGetter()
STDERR: #5 0x000004d8faa2 blink::V8CSSStyleDeclaration::namedPropertyGetterCallback()
STDERR: #6 0x0000024ec8f4 v8::internal::PropertyCallbackArguments::BasicCallNamedGetterCallback()
STDERR: #7 0x0000024ec5f8 v8::internal::PropertyCallbackArguments::CallNamedGetter()
STDERR: #8 0x0000024e9570 v8::internal::__RT_impl_Runtime_LoadPropertyWithInterceptor()
STDERR: #9 0x1aeb3e984252 <unknown>
STDERR: 

The line in question:
https://chromium.googlesource.com/chromium/src/+blame/d35f7c6107242ba8ef7df7335ba2eeda07e8da82/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp#759

Last touched by rjwright@.
 
Also affects external/wpt/css/css-fonts/variations/font-style-interpolation.html
Cc: drott@chromium.org cnardi@chromium.org
The test came from https://github.com/w3c/web-platform-tests/pull/9373, adding people involved there.

Comment 3 by drott@chromium.org, Apr 4 2018

Blocking: 809920
Cc: futhark@chromium.org foolip@chromium.org
 Issue 828748  has been merged into this issue.

Comment 5 by f...@opera.com, Apr 4 2018

Mergedinto: 809938
Status: Duplicate (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82b3aa45b67402a6dc2e81ce6abf003fd5d25bb

commit e82b3aa45b67402a6dc2e81ce6abf003fd5d25bb
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Apr 04 11:42:05 2018

Mark external/wpt/css/css-fonts/variations/font-style-interpolation.html as Timeout

It's timing out in the wpt-importer runs and resulting in "Duplicate
or ambiguous entry lines":
https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15345

Also update the bug numbers.

No-Try: true
TBR: raphael.kubo.da.costa@intel.com
Bug:  828746 
Change-Id: Iec0188a4e5ae45a65c7df7fe1de6be627ddd4684
Reviewed-on: https://chromium-review.googlesource.com/995432
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548020}
[modify] https://crrev.com/e82b3aa45b67402a6dc2e81ce6abf003fd5d25bb/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment