Make V8 autorollers use roll-dep or gclient setdep rather than roll-dep-svn |
|||||
Issue descriptionroll-dep-svn is deprecated. This will be done after migrating Auto-roll builders to LUCI to allow testing them with roll-dep/gclient-setdep using led.
,
Apr 4 2018
It's only blocked on migrating auto-rollers, but I don't have a separate bug for that... just a generic LUCI migration bug. Since you've assigned this to me, this should now be gone from the Untriaged queue.
,
Apr 4 2018
,
Apr 5 2018
I'll evaluate if we can just switch right now. We don't really need to test with led. If the roller breaks, we can just revert.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9 commit a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9 Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Apr 05 10:37:19 2018 [release] Switch auto-roller to gclient setdep NOTRY=true Bug: chromium:828745 Change-Id: I051f57893937796e01f0b823f1050dd36e0fbfd9 Reviewed-on: https://chromium-review.googlesource.com/997556 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52385} [modify] https://crrev.com/a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9/tools/release/auto_roll.py [modify] https://crrev.com/a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9/tools/release/test_scripts.py
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d76624c4d59c9d281452a9d5f99725a4560b1e2c commit d76624c4d59c9d281452a9d5f99725a4560b1e2c Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Apr 05 10:41:52 2018 [V8] Switch deps roller to gclient setdep Bug: 828745 Change-Id: If3040bfe86ae0422c9208fc9799a32fe6711e3e5 Reviewed-on: https://chromium-review.googlesource.com/997633 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/d76624c4d59c9d281452a9d5f99725a4560b1e2c/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/roll.json [modify] https://crrev.com/d76624c4d59c9d281452a9d5f99725a4560b1e2c/scripts/slave/recipes/v8/auto_roll_v8_deps.py
,
Apr 5 2018
Awesome. Thank you.
,
Apr 5 2018
Still testing the new code. Sadly both rollers are stuck on something else...
,
Apr 6 2018
Both roller working. This should be fixed and roll-dep-svn isn't used anymore by V8.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d169622f83d82eb5f5203d921bc3209b3e2a12b4 commit d169622f83d82eb5f5203d921bc3209b3e2a12b4 Author: Michael Achenbach <machenbach@chromium.org> Date: Thu May 17 12:09:59 2018 Revert "[release] Switch auto-roller to gclient setdep" This reverts commit a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9. Reason for revert: Temporarily use legacy method until https://crbug.com/843917 is fixed. Original change's description: > [release] Switch auto-roller to gclient setdep > > NOTRY=true > > Bug: chromium:828745 > Change-Id: I051f57893937796e01f0b823f1050dd36e0fbfd9 > Reviewed-on: https://chromium-review.googlesource.com/997556 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52385} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org NOTRY=true Bug: chromium:843917 Change-Id: I69978ba55ffa5996101e1d31bdf10364b7ef273f Reviewed-on: https://chromium-review.googlesource.com/1064130 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53230} [modify] https://crrev.com/d169622f83d82eb5f5203d921bc3209b3e2a12b4/tools/release/auto_roll.py [modify] https://crrev.com/d169622f83d82eb5f5203d921bc3209b3e2a12b4/tools/release/test_scripts.py
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/90e61da1c6b2e6d229bb6d79d1a09d901513d9e6 commit 90e61da1c6b2e6d229bb6d79d1a09d901513d9e6 Author: Michael Achenbach <machenbach@chromium.org> Date: Thu May 17 16:24:31 2018 Reland "[release] Switch auto-roller to gclient setdep" This reverts commit d169622f83d82eb5f5203d921bc3209b3e2a12b4. Reason for revert: setdep bug should be fixed Original change's description: > Revert "[release] Switch auto-roller to gclient setdep" > > This reverts commit a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9. > > Reason for revert: > Temporarily use legacy method until https://crbug.com/843917 is fixed. > > Original change's description: > > [release] Switch auto-roller to gclient setdep > > > > NOTRY=true > > > > Bug: chromium:828745 > > Change-Id: I051f57893937796e01f0b823f1050dd36e0fbfd9 > > Reviewed-on: https://chromium-review.googlesource.com/997556 > > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#52385} > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > NOTRY=true > > Bug: chromium:843917 > Change-Id: I69978ba55ffa5996101e1d31bdf10364b7ef273f > Reviewed-on: https://chromium-review.googlesource.com/1064130 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53230} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia70dc1df7e25e0c8ffd3fafeb97830b5d5f87336 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843917 Reviewed-on: https://chromium-review.googlesource.com/1064413 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53238} [modify] https://crrev.com/90e61da1c6b2e6d229bb6d79d1a09d901513d9e6/tools/release/auto_roll.py [modify] https://crrev.com/90e61da1c6b2e6d229bb6d79d1a09d901513d9e6/tools/release/test_scripts.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by machenb...@chromium.org
, Apr 4 2018Status: Assigned (was: Untriaged)