Tab grid - Tabs appear misaligned in tab grid when device is rotated to landscape |
|||||||||||
Issue descriptionApp Version: 67.0.3388.0 canary iOS Version: 10.3.3, 11.4 beta Device: iPhone 7 Plus, iPhone X, iPad Mini Prerequisite: Enable ‘UI Refresh Phase 1 (#ui-refresh-phase-1) flag from chrome flags Steps to reproduce: 1. Launch iOS Chrome 2. Change the device orientation to landscape 3. Tap on tab switcher icon Observed results: Tabs appear misaligned and incognito tab is displayed Expected results: Tabs should be aligned properly and incognito tabs should not be displayed in normal mode when device is rotated to landscape Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on the current stable build :M65, NA (New Feature) Bug reproducible on the current beta channel build :M66, NA (New Feature) Type-bug-regression? No Link to Image/Video https://drive.google.com/open?id=120LA6ZndygTZwJeAcaiQUxQx9KHVlwUG
,
Apr 5 2018
,
Apr 5 2018
,
Apr 5 2018
,
Apr 5 2018
Removing release blocker since this is hidden behind a flag.
,
Apr 5 2018
,
Apr 5 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a606972d0f1f6c28af88f6f23b272bb0422988d1 commit a606972d0f1f6c28af88f6f23b272bb0422988d1 Author: edchin <edchin@chromium.org> Date: Thu Apr 05 20:29:12 2018 [ios] Fix rotations in tab grid The tab grid was not behaving properly in rotations. The page would change when it is not supposed to. This is due to the page being set inside |-scrollViewDidScroll:| while the rotation was occurring. The fix is to separately set the page for non-user-dragging scroll in |-scrollViewDidEndScrollingAnimation:|. Bug: 828735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib325eb6ef5d5ebb98274ec565cdbb03a21b8e9e1 Reviewed-on: https://chromium-review.googlesource.com/998055 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548541} [modify] https://crrev.com/a606972d0f1f6c28af88f6f23b272bb0422988d1/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Apr 6 2018
,
Apr 11 2018
Issue is still reproducible. Checked on latest chrome canary version 67.0.3394.0 on iPhone 8 plus, iPhone 7 plus, iPad Pro with iOS 11.2.6, 10.3.3.
,
Jun 22 2018
I can't reproduce this. The video is really bad, but I don't see that behavior given the steps listed. Leaving P1 for now.
,
Jun 25 2018
,
Aug 24
Verified on chrome beta version 69.0.3497.58 on iPhone 8 plus with iOS 11.4.1, iPhone 6s plus with iOS 12 beta 9. Issue is not reproducible. Looks good. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by justincohen@chromium.org
, Apr 4 2018Owner: marq@chromium.org
Status: Assigned (was: Untriaged)