Implement SkCanvas::readImage |
||||
Issue descriptionCurrently Skia GPU path has no support to copy out framebuffer as a texture, like glCopyTexImage2D does. But only SkCanvas::readPixels/glReadPixels. glReadPixels requires extra effort to copy memory from CPU to GPU if we need to use this as a texture, this will slow down backdrop filter.
,
Apr 4 2018
,
Apr 4 2018
,
Apr 11 2018
As commented by enne@, this can be done by SkSurface::makeImageSnapshot. So I am OK to close this. https://chromium-review.googlesource.com/c/chromium/src/+/985635/7/components/viz/service/display/skia_renderer.cc#752
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b commit a13c5f52e732af62438d9ab9588fb9cc00a6fb2b Author: Xu Xing <xing.xu@intel.com> Date: Fri Apr 20 04:30:56 2018 viz: Support background filter in SkiaRenderer This passes all current css/filters layout tests and skia renderer backdrop filter pixel test. Remove the TODO(skaslev): The software renderer does not support filters yet. BUG=822857, 828728 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6f96259249612e8655c953bdd6a534ae9f5c6acc Reviewed-on: https://chromium-review.googlesource.com/985635 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552260} [modify] https://crrev.com/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b/components/viz/service/display/renderer_pixeltest.cc [modify] https://crrev.com/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b/components/viz/service/display/skia_renderer.cc [modify] https://crrev.com/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b/components/viz/service/display/skia_renderer.h
,
May 2 2018
As copmmentted by @enne, this can be done by SkSurface::makeImageSnapshot. So close this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by xing...@intel.com
, Apr 4 2018