New issue
Advanced search Search tips

Issue 828686 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Create autotests for the Omaha Config: "PackageItem" manual tests

Project Member Reported by dhadd...@chromium.org, Apr 4 2018

Issue description

Automate section 14 of the AU manual tests:
https://testtracker.googleplex.com/testplans/details/450

I will create an autotest for this to remove the need for us to it manually during our FullRelease test passes. And it will give us much greater coverage than we have ever had
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bcabe44e87bd389ef4401b112a88388d11cd9247

commit bcabe44e87bd389ef4401b112a88388d11cd9247
Author: David Haddock <dhaddock@chromium.org>
Date: Tue Apr 10 20:44:12 2018

More tests for bad data in omaha response.

This adds on the previous autoupdate_OmahaResponse CL to add tests for
dealing with bad metadata_size and SHA256 values in the omaha response.

It is automating the test cases in section 1.14 here:
https://testtracker.googleplex.com/testplans/details/450

This CL adds a new client test autoupdate_BadMetadata that will do the
actual checking and handling of the update.

The server test (autoupdate_OmahaResponse) was updated to call this new
test.

This CL also adds a raise_error boolean to
check_update_engine_log_for_entry that I forgot to add to the last CL.

BUG= chromium:828686 
TEST=autoupdate_OmahaResponse.local with all 3 tests.

Change-Id: I0e8f9fe193e07c8a5d364d7101c99f49743428cc
Reviewed-on: https://chromium-review.googlesource.com/994261
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[add] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/server/site_tests/autoupdate_OmahaResponse/control.bad_sha256.full
[add] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/server/site_tests/autoupdate_OmahaResponse/control.bad_metadata_size.full
[modify] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/server/site_tests/autoupdate_OmahaResponse/control.local
[modify] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/server/site_tests/autoupdate_OmahaResponse/autoupdate_OmahaResponse.py
[add] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/client/site_tests/autoupdate_BadMetadata/control
[modify] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/client/cros/update_engine/update_engine_test.py
[add] https://crrev.com/bcabe44e87bd389ef4401b112a88388d11cd9247/client/site_tests/autoupdate_BadMetadata/autoupdate_BadMetadata.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/631daed54aabeae841a28eb0095e2cba2b6bb0d0

commit 631daed54aabeae841a28eb0095e2cba2b6bb0d0
Author: David Haddock <dhaddock@chromium.org>
Date: Tue Apr 10 23:29:21 2018

Add autoupdate_BadMetadata to ebuild.

BUG= chromium:828686 
CQ-DEPEND=CL:994261
TEST=autoupdate_OmahaResponse.local is passing

Change-Id: I1a5984028ccab8f32af3ffe458a7489cd1f6b59b
Reviewed-on: https://chromium-review.googlesource.com/1000954
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/631daed54aabeae841a28eb0095e2cba2b6bb0d0/chromeos-base/autotest-tests/autotest-tests-9999.ebuild

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment