gen/angle/id/commit.h not always regenerated |
||||
Issue descriptionFor example in this build (failing for unrelated reasons): https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/136299 the GL_VERSION is reported as: INFO:root: gl_version : OpenGL ES 2.0 (ANGLE 2.1.0.96310cdad317) when in fact got_angle_revision the correct one, from DEPS: 30b604d8d17480bd519fb97ec817db1e4ca90f0e The commit id is updated here: https://cs.chromium.org/chromium/src/third_party/angle/BUILD.gn?l=358&rcl=30b604d8d17480bd519fb97ec817db1e4ca90f0e which is a build rule with no dependencies. So, probably it never/rarely gets rerun after it is first generated. It may be necessary to run a script in DEPS, like Skia does: https://cs.chromium.org/chromium/src/DEPS?l=1117&rcl=98abd37767e4398aeb5ad199846fac075f757422
,
Aug 3
,
Aug 7
I made CL. https://chromium-review.googlesource.com/c/angle/angle/+/1164814
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/c93eeaab15269253593e929abce8cdfea52242ef commit c93eeaab15269253593e929abce8cdfea52242ef Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Aug 07 22:59:34 2018 Make angle's commit.h depend on git head This is for reproducible build of angle related libraries. Bug: 828669 Change-Id: I807c8fb01b976f6e7a71477ee934b9e0b0cdc684 Reviewed-on: https://chromium-review.googlesource.com/1164814 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/c93eeaab15269253593e929abce8cdfea52242ef/BUILD.gn
,
Aug 8
Angle's CL was rolled in https://chromium-review.googlesource.com/c/chromium/src/+/1165904 |
||||
►
Sign in to add a comment |
||||
Comment 1 by jmad...@chromium.org
, Aug 3