New issue
Advanced search Search tips

Issue 828660 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Piper roll broken at build #19769

Project Member Reported by kkhorimoto@chromium.org, Apr 3 2018

Issue description

cl/191678404

Comment 3 by pkl@chromium.org, Apr 9 2018

Cc: stkhapugin@chromium.org pkl@chromium.org
Labels: M-67
M67 branch is this week. Is CL in comment 2 ready to submit? Or does this need to be handed off to the next owner (stk@)?


The CL is ready to submit, but I need to run the git5 script to pull the new files in from the p4_depot_paths CL in comment 1

Comment 5 by pkl@chromium.org, Apr 10 2018

pkl-macbookpro3:src(merge1) pkl$ git push origin merge1:master
Counting objects: 1019, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (546/546), done.
Writing objects: 100% (1019/1019), 176.32 KiB | 19.59 MiB/s, done.
Total 1019 (delta 458), reused 843 (delta 307)
remote: Resolving deltas: 100% (458/458)           
remote: Counting objects: 1019, done        
remote: Replicating objects... done        
remote: Processing changes: done            
To sso://bling-internal/piper.git
   e9cc6110c8..627c82218c  merge1 -> master

Updating crrev.com/i/602393 to include the new changes; I'll CQ when it's ready.
Additional files from piper were required to fix the roll, and have been added to our p4_depot_paths here: cl/192347022

crrev.com/i/602393 will be updated once again to include these new files once that CL lands.
Thank you for doing this. Feel free to hang this over to me whenever you want to, it's my shift! :) 
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/00c643240013c6a9cc79bd3659ddbe10ac8f8b1c

commit 00c643240013c6a9cc79bd3659ddbe10ac8f8b1c
Author: Kurt Horimoto <kkhorimoto@google.com>
Date: Wed Apr 11 18:59:06 2018

Status: Fixed (was: Started)

Sign in to add a comment