Wrong caret position with 'unicode-bidi: plaintext' overriding different block direction |
||
Issue descriptionChrome Version: Stable 65.0.3325.181 and ToT @r547783 OS: Linux What steps will reproduce the problem? (1) Test url: https://jsfiddle.net/ekwLhckc/7/ (2) Focus the contenteditable div, and press HOME key What is the expected result? Caret appears at the left edge of text What happens instead? Caret appears at the right edge of text
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a93bb17fb2477de9bddce5c0275f422b1cb1cce commit 6a93bb17fb2477de9bddce5c0275f422b1cb1cce Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Apr 04 05:23:15 2018 Fix 'unicode-bidi: plaintext' handling in ComputeInlineBoxPosition Existing code performs bidi adjustment for 'unicode-bidi: plaintext' only for the right edge of InlineBoxes. This patch makes it handle both edges to allow caret to appear at the left edge. This patch also makes the bidi adjustment code symmetric for left and right edge handling, so that we can de-duplicate in future refactoring. Bug: 828657 , 771398 Change-Id: I3fd22280327c7186fcfddfb0ba1bb13c4a5dfeff Reviewed-on: https://chromium-review.googlesource.com/994389 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547987} [modify] https://crrev.com/6a93bb17fb2477de9bddce5c0275f422b1cb1cce/third_party/WebKit/Source/core/editing/InlineBoxPosition.cpp [modify] https://crrev.com/6a93bb17fb2477de9bddce5c0275f422b1cb1cce/third_party/WebKit/Source/core/editing/LocalCaretRectTest.cpp
,
Apr 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by xiaoche...@chromium.org
, Apr 3 2018