OOBE Assistant logo loading from network in Web UI |
||
Issue descriptionHi khmel@, sorry to bug you again so soon with another issue! This is similar to bug 824952, but it's for the Assistant logo this time. Specifically this is the offending resource load: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/oobe_wait_for_container_ready.html?rcl=85442de7fc86342e1405446754b6ef405ea4fe90&l=12
,
Apr 4 2018
,
Apr 4 2018
Wow, thank you for the incredibly fast turn-around on this! :O
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f69043196ee3e5e3543e2c8ef2b45adeed4ff442 commit f69043196ee3e5e3543e2c8ef2b45adeed4ff442 Author: khmel@google.com <khmel@google.com> Date: Wed Apr 04 17:07:04 2018 arc: Use static Assitant logo in OOBE. This replaces external reference of Assistant logo in OOBE OptIn to internal static icon. Test: Manually Bug: 828642 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d0c42acf53095af14c31fc1d64ab5f4731a9509 Reviewed-on: https://chromium-review.googlesource.com/994732 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#548103} [modify] https://crrev.com/f69043196ee3e5e3543e2c8ef2b45adeed4ff442/chrome/browser/browser_resources.grd [add] https://crrev.com/f69043196ee3e5e3543e2c8ef2b45adeed4ff442/chrome/browser/resources/chromeos/assistant_optin/assistant_logo.png [modify] https://crrev.com/f69043196ee3e5e3543e2c8ef2b45adeed4ff442/chrome/browser/resources/chromeos/login/oobe_wait_for_container_ready.html [modify] https://crrev.com/f69043196ee3e5e3543e2c8ef2b45adeed4ff442/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Apr 4 2018
#3 - np :) was low-hanging fruit. |
||
►
Sign in to add a comment |
||
Comment 1 by khmel@chromium.org
, Apr 3 2018