New issue
Advanced search Search tips

Issue 828641 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AnalyserOptions members have incorrect type

Project Member Reported by rtoy@chromium.org, Apr 3 2018 
The current idl for AnalyserOptions says:

dictionary AnalyserOptions : AudioNodeOptions {
    unsigned long fftSize = 2048;
    float maxDecibels = -30;
    float minDecibels = -100;
    float smoothingTimeConstant = 0.8;
};

All of the attributes are supposed to have type double: https://webaudio.github.io/web-audio-api/#dictdef-analyseroptions
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dbf079bb6e1415cfcd4e01324cbd8a33fbc89c9

commit 9dbf079bb6e1415cfcd4e01324cbd8a33fbc89c9
Author: Raymond Toy <rtoy@chromium.org>
Date: Fri Apr 06 01:22:57 2018

AnalyserOptions members are doubles

The members of the AnalyserOptions dictionary should have type double,
not float.

See https://webaudio.github.io/web-audio-api/#dictdef-analyseroptions

We also correct the spec link in the idl file.

Bug:  828641 
Test: webaudio/constructor/analyser.html
Change-Id: I25bace0d20a7e41a6e03e06999d724f0706371e1
Reviewed-on: https://chromium-review.googlesource.com/994374
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548629}
[modify] https://crrev.com/9dbf079bb6e1415cfcd4e01324cbd8a33fbc89c9/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
[modify] https://crrev.com/9dbf079bb6e1415cfcd4e01324cbd8a33fbc89c9/third_party/WebKit/Source/modules/webaudio/AnalyserOptions.idl

Comment 2 by rtoy@chromium.org, Apr 11 2018

Status: Fixed (was: Started)
►

Sign in to add a comment