New issue
Advanced search Search tips

Issue 828638 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gn gen --filters= argument breaks build

Project Member Reported by jdarpinian@chromium.org, Apr 3 2018

Issue description

I'm using --filters= to reduce the size of my visual studio solution. Today when I run ninja after gn gen, it tries to regenerate the build files even though nothing has changed, and immediately fails with "ERROR No Visual Studio projects generated."

C:\src\chrome\src>gn gen out/Release --ide=vs --ninja-extra-args="-j 240" --filters=gpu;third_party/angle
Generating Visual Studio projects took 108ms
Done. Made 8471 targets from 1486 files in 3549ms
C:\src\chrome\src>ninja -C out/Release chrome
ninja: Entering directory `out/Release'
[1/1] Regenerating ninja files
FAILED: build.ninja
../../../../../..///src/chrome/src/buildtools/win/gn.exe --root=../.. -q --filters=gpu;third_party/angle --ide=vs --ninja-extra-args="-j 240" gen .
ERROR No Visual Studio projects generated.
ninja: error: rebuilding 'build.ninja': subcommand failed

The only workaround I can find is removing --filters=, but that makes it near-impossible to use the generated Visual Studio project.
 
Cc: yn...@vivaldi.com
Owner: dpranke@chromium.org
Status: Available (was: Untriaged)
Ah, I found a better workaround, specifying // in front of every filter fixes it. Looks like there's a patch on the way to fix this behavior as well. https://chromium-review.googlesource.com/c/chromium/src/+/941209

Comment 2 by yn...@vivaldi.com, Apr 4 2018

FYI, https://chromium-review.googlesource.com/c/chromium/src/+/941209 have now been merged to master

Comment 3 by yn...@vivaldi.com, Apr 4 2018

Note, however, that getting the fixed functionality requires that the released GN executables are updated.
Owner: ----
Status: Fixed (was: Available)
I think this is fixed now.

Sign in to add a comment