New issue
Advanced search Search tips

Issue 828636 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jul 10
Cc:
amaralp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 825965
issue 847620



Sign in to add a comment

Bottom toolbar should be visible when swiping on the toolbar

Project Member Reported by mdjones@chromium.org, Apr 3 2018 
The bottom toolbar should be visible when swiping on the top toolbar to switch tabs (ToolbarSwipeLayout). The toolbar should move with the tab that's associated with it like the top toolbar does (the android view should not be visible).

The toolbar swiping behavior should also be applied to the bottom toolbar.

Comment 1 by mdjones@chromium.org, Apr 3 2018

Description: Show this description

Comment 2 by mdjones@chromium.org, Apr 9 2018

Cc: -amaralp@chromium.org
Owner: amaralp@chromium.org
Status: Assigned (was: Available)

Comment 3 by mdjones@chromium.org, Jun 4 2018

Blocking: 847620
Labels: -Type-Bug -Pri-2 android-bottom-toolbar Pri-3 Type-Task
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c96e72961e04851512478a62a07656640f96fd3e

commit c96e72961e04851512478a62a07656640f96fd3e
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Jul 10 21:22:34 2018

Animate the bottom toolbar with the page in toolbar swipe

This patch allows the bottom toolbar to move synchronously with the
page when using the toolbar swipe functionality. The ToolbarSwipeLayout
is provided with two SceneLayers that draw the bottom toolbar which
it then positions however needed.

Bug:  828636 
Change-Id: I6bd3f9a9d3c90744205fec25d6a2090509a2f041
Reviewed-on: https://chromium-review.googlesource.com/1120685
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573913}
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ScrollingBottomViewSceneLayer.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/browser/android/compositor/scene_layer/scrolling_bottom_view_scene_layer.cc
[modify] https://crrev.com/c96e72961e04851512478a62a07656640f96fd3e/chrome/browser/android/compositor/scene_layer/scrolling_bottom_view_scene_layer.h

Comment 5 by mdjones@chromium.org, Jul 10

Cc: -mdjones@chromium.org amaralp@chromium.org
Owner: mdjones@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment