New issue
Advanced search Search tips

Issue 828628 link

Starred by 1 user
Status: Fixed
Owner:
obru...@igalia.com
Closed: Yesterday
Cc:
jfernan...@igalia.com
r...@igalia.com
svil...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-grid] Issue with abspos element which containing block is the grid container

Project Member Reported by r...@igalia.com, Apr 3 2018 

See the attached example, the abspos element is a child of the grid item.
The containing block is the grid container.

If you set the offset in just one axis (e.g. "left: 0"), the abspos element
is moved to the left but also to the top (losing its static position
in the vertical axis), which shouldn't happen.

This works fine in Firefox, we should manage this per axis (inline or block)
independently.
bug-abspos.html
369 bytes View Download
bug-abspos.png
15.1 KB View Download

Comment 1 by r...@igalia.com, Jan 9

Owner: obru...@igalia.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Yesterday (45 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa95a924fb898513d91b0873ef122c5e52f80868

commit fa95a924fb898513d91b0873ef122c5e52f80868
Author: Oriol Brufau <obrufau@igalia.com>
Date: Mon Jan 21 15:41:07 2019

[css-grid] Properly handle static positions of abspos inside grid items

Currently they are aligned to zero instead of to their static position
if an explicit offset is provided for the opposite axis.

Various orthogonal tests fail without LayoutNG because of
http://crbug.com/883574

Spec: https://drafts.csswg.org/css-grid/#abspos

BUG= 828628 

TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-001.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-002.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-003.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-004.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-005.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-006.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-007.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-008.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-009.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-010.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-011.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-012.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-013.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-014.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-015.html
TEST=external/wpt/css/css-grid/abspos/positioned-grid-descendants-016.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-006.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-008.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-009.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-011.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-012.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-014.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html
TEST=external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-016.html

Change-Id: If52ee6148862587c7f2fe3453e6b863b859324ee
Reviewed-on: https://chromium-review.googlesource.com/c/1415294
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624586}
[modify] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/renderer/core/layout/layout_grid.cc
[modify] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/renderer/core/layout/layout_grid.h
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-006.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-008.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-009.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-011.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-012.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-014.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-016.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-001.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-002.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-003.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-004.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-005.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-006.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-007.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-008.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-009.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-010.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-011.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-012.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-013.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-014.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-015.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/positioned-grid-descendants-016.html
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/support/positioned-grid-descendants.css
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/external/wpt/css/css-grid/abspos/support/positioned-grid-descendants.js
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007-expected.txt
[add] https://crrev.com/fa95a924fb898513d91b0873ef122c5e52f80868/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/external/wpt/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010-expected.txt

Comment 3 by obru...@igalia.com, Yesterday (39 hours ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment