New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828612 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 781754



Sign in to add a comment

Add feature flags for WebSettingsCompat APIs

Project Member Reported by gsennton@chromium.org, Apr 3 2018

Issue description

The WebSettingsCompat APIs need feature flags associated with them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc82b2cb5c9e356f3a5502de77b17a2133a64d9f

commit cc82b2cb5c9e356f3a5502de77b17a2133a64d9f
Author: Gustav Sennton <gsennton@google.com>
Date: Fri Apr 06 17:13:53 2018

[android webview] Add feature flags for lots of APIs

We need to guard support library method calls with feature flags to
ensure the methods are only called on webview / support library version
where they're supported.
In this CL we add feature flags for various APIs related to
WebSettings, SafeBrowsing, and ServiceWorkers.

Bug:  828612 
Bug:  819595 
Bug:  816506 
Change-Id: Ice5f5645040ab7316ef90322812ca6319e8a2351
Reviewed-on: https://chromium-review.googlesource.com/995933
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548828}
[modify] https://crrev.com/cc82b2cb5c9e356f3a5502de77b17a2133a64d9f/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[modify] https://crrev.com/cc82b2cb5c9e356f3a5502de77b17a2133a64d9f/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Status: Fixed (was: Assigned)

Sign in to add a comment