Collect UMA info on variations seed load status & blocking time in WebView |
||||||||
Issue descriptionWebView's variations seed loading code added in https://chromium-review.googlesource.com/c/chromium/src/+/954058 should be instrumented so we can see whether seed loading is successful and how long WebView startup was blocked waiting for loading to finish.
,
Apr 3 2018
We should only log these metrics if variations is enabled. Experiment status as a separate histogram wouldn't allow us to split these metrics.
,
Apr 4 2018
We want this for the experiment with AGSA in m67.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58467fe35f0732961cf6cb0c4f39c9cb21da1515 commit 58467fe35f0732961cf6cb0c4f39c9cb21da1515 Author: Paul Miller <paulmiller@google.com> Date: Fri Apr 27 00:54:01 2018 Instrument variations seed loading in WebView Variations.SeedLoadBlockingTime tells us how long WebView startup is delayed waiting for the seed. This is less than the total time to load the seed, because we block after loading has already started. Variations.SeedLoadResult tells us whether the load was successful. Its VariationsSeedLoadResult enum is extended to include failure modes for the FutureTask that WebView uses to load the seed. WebView is still using dummy seed files without actual seed data, so the enum's various seed corruption values aren't yet applicable. BUG= 828610 Change-Id: If9af5a82cedf990cf670f6b0dcf123ac10ea69bb Reviewed-on: https://chromium-review.googlesource.com/994253 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554240} [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/android_webview/BUILD.gn [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/android_webview/java/src/org/chromium/android_webview/VariationsSeedLoader.java [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/android_webview/javatests/src/org/chromium/android_webview/test/VariationsSeedLoaderTest.java [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/components/variations/BUILD.gn [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/components/variations/metrics.h [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/tools/metrics/histograms/enums.xml [modify] https://crrev.com/58467fe35f0732961cf6cb0c4f39c9cb21da1515/tools/metrics/histograms/histograms.xml
,
Apr 27 2018
,
Apr 27 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2018
,
May 7 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17ef7181e3d2e767d14d95b7c807b34e0929478f commit 17ef7181e3d2e767d14d95b7c807b34e0929478f Author: Paul Miller <paulmiller@google.com> Date: Tue May 08 18:55:32 2018 Instrument variations seed loading in WebView Variations.SeedLoadBlockingTime tells us how long WebView startup is delayed waiting for the seed. This is less than the total time to load the seed, because we block after loading has already started. Variations.SeedLoadResult tells us whether the load was successful. Its VariationsSeedLoadResult enum is extended to include failure modes for the FutureTask that WebView uses to load the seed. WebView is still using dummy seed files without actual seed data, so the enum's various seed corruption values aren't yet applicable. BUG= 828610 Change-Id: If9af5a82cedf990cf670f6b0dcf123ac10ea69bb Reviewed-on: https://chromium-review.googlesource.com/994253 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554240}(cherry picked from commit 58467fe35f0732961cf6cb0c4f39c9cb21da1515) Reviewed-on: https://chromium-review.googlesource.com/1048906 Reviewed-by: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#525} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/android_webview/BUILD.gn [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/android_webview/java/src/org/chromium/android_webview/VariationsSeedLoader.java [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/android_webview/javatests/src/org/chromium/android_webview/test/VariationsSeedLoaderTest.java [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/components/variations/BUILD.gn [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/components/variations/metrics.h [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/tools/metrics/histograms/enums.xml [modify] https://crrev.com/17ef7181e3d2e767d14d95b7c807b34e0929478f/tools/metrics/histograms/histograms.xml
,
May 8 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by changwan@chromium.org
, Apr 3 2018