New issue
Advanced search Search tips

Issue 828600 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace raw pointers with smart pointers in update_client::URLRequestPostInterceptor

Project Member Reported by sorin@chromium.org, Apr 3 2018

Issue description

Understanding ownership of various objects such as interceptors is difficult in the current implementation, and it is prone to memory leaks and accessing dangling objects.

There is follow-up work to implement support for pausing such interceptors. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015681f16c67705b80301206ed83ea6d3540fb56

commit 015681f16c67705b80301206ed83ea6d3540fb56
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed Apr 04 16:43:33 2018

Replace raw pointers with smart pointers in update_client::URLRequestPostInterceptor

This is a mechanical change. Understanding ownership of various objects such as interceptors
is difficult in the current implementation, and it is prone to memory leaks and
accessing dangling objects.

There is follow-up work to implement support for pausing such interceptors.

Bug:  828600 
Change-Id: Ic88e76be4adc45e0f341f13ff888fd1612b157a6
Reviewed-on: https://chromium-review.googlesource.com/991471
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548094}
[modify] https://crrev.com/015681f16c67705b80301206ed83ea6d3540fb56/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/015681f16c67705b80301206ed83ea6d3540fb56/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/015681f16c67705b80301206ed83ea6d3540fb56/components/update_client/request_sender_unittest.cc
[modify] https://crrev.com/015681f16c67705b80301206ed83ea6d3540fb56/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/015681f16c67705b80301206ed83ea6d3540fb56/components/update_client/url_request_post_interceptor.cc
[modify] https://crrev.com/015681f16c67705b80301206ed83ea6d3540fb56/components/update_client/url_request_post_interceptor.h

Comment 2 by sorin@chromium.org, Apr 5 2018

Status: Fixed (was: Started)

Sign in to add a comment