New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 828590 link

Starred by 1 user
Status: Fixed
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

exonerator should work on annotations that were finalized prior to end of cq run

Project Member Reported by akes...@chromium.org, Apr 3 2018 
Example order of events:

1) CQ run starts.
2) Some slave fails.
3) Sheriff notices failure, finds something to blame, adds annotation to run, and clicks finalize.
4) CQ rejects a bunch of CLs and then finishes.

In this circumstance, the exonerator will not exonerate the CLs that were rejected in #4. But it should.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/5936ef9e3d57b3cf8835502a3cc138396618e70c

commit 5936ef9e3d57b3cf8835502a3cc138396618e70c
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 13 18:07:17 2018

checkpointlib: Move checkpoint helper function

This will be used by innocent_cls_cq.py as well, so move it into its own module.

TEST=innocent_cls_precq_test
BUG= chromium:828590 

Change-Id: I33372eb4f80ce8d6e92f82c5a119e58fd74c43e1

[add] https://crrev.com/5936ef9e3d57b3cf8835502a3cc138396618e70c/exonerator/checkpointlib.py
[modify] https://crrev.com/5936ef9e3d57b3cf8835502a3cc138396618e70c/exonerator/innocent_cls_cq.py
[modify] https://crrev.com/5936ef9e3d57b3cf8835502a3cc138396618e70c/exonerator/innocent_cls_precq.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/a6250069ceb1ab7997ae1ceeea8ebd5c444884bc

commit a6250069ceb1ab7997ae1ceeea8ebd5c444884bc
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 13 18:07:17 2018

innocent_cls_cq: Use CheckpointSequence

Reuse checkpointing logic from checkpointlib

BUG= chromium:828590 
TEST=None

Change-Id: I0475b232d3e4eaab879d5594c66f6a23f03f2faf

[modify] https://crrev.com/a6250069ceb1ab7997ae1ceeea8ebd5c444884bc/exonerator/innocent_cls_cq.py
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/01e608122f74dbaff51c943ca38db27f9ee6397c

commit 01e608122f74dbaff51c943ca38db27f9ee6397c
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 13 18:20:42 2018

innocent_cls_cq: Use per-build checkpointing

Use a separate entity per build processed. This allows us to defer processing an
annotation until later if the build hasn't finished yet.

BUG= chromium:828590 
TEST=innocent_cls_cq_test passes

Change-Id: Id8c158f4986d77a1fde88b90bb52877447ced609

[modify] https://crrev.com/01e608122f74dbaff51c943ca38db27f9ee6397c/exonerator/innocent_cls_cq_test.py
[modify] https://crrev.com/01e608122f74dbaff51c943ca38db27f9ee6397c/exonerator/innocent_cls_cq.py

Comment 4 by pho...@chromium.org, Apr 20 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment