New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828586 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
67



Sign in to add a comment

ARC++ window resize is broken

Project Member Reported by osh...@chromium.org, Apr 3 2018

Issue description

Drag the top does not move up the window.(grows downwards)

Geometry isn't updated and resize shadow remains the same until resize is finished.
 
bisecting now
Cc: omrilio@chromium.org x...@chromium.org osh...@chromium.org
 Issue 828595  has been merged into this issue.
Owner: osh...@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/994173
Cc: reve...@chromium.org
crrev.com/c/986515 is the culprit.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abbd025a6e057425ae5768fa251f9a1b6874f45

commit 0abbd025a6e057425ae5768fa251f9a1b6874f45
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Apr 05 15:39:56 2018

Don't skip updating widget when resizing ClientControlledShellSurface

ClientControlledShellSurface doesn't use configure to resize.

BUG= 828586 
TEST=manual

Change-Id: I19c165741917f8a6855fab20a5938e9b020e02c0
Reviewed-on: https://chromium-review.googlesource.com/994173
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548433}
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/components/exo/shell_surface_base.cc
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/components/exo/surface_delegate.h
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/components/exo/wayland/server.cc
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/0abbd025a6e057425ae5768fa251f9a1b6874f45/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c

commit 85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Apr 05 16:15:17 2018

Revert "Don't skip updating widget when resizing ClientControlledShellSurface"

This reverts commit 0abbd025a6e057425ae5768fa251f9a1b6874f45.

Reason for revert: other git cl upload uploaded the wrong CL.

Original change's description:
> Don't skip updating widget when resizing ClientControlledShellSurface
> 
> ClientControlledShellSurface doesn't use configure to resize.
> 
> BUG= 828586 
> TEST=manual
> 
> Change-Id: I19c165741917f8a6855fab20a5938e9b020e02c0
> Reviewed-on: https://chromium-review.googlesource.com/994173
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548433}

TBR=reveman@chromium.org,oshima@chromium.org

Change-Id: Iac7a79ec338601463261650cbfcec5f91ea44a61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  828586 
Reviewed-on: https://chromium-review.googlesource.com/998172
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548441}
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/components/exo/shell_surface_base.cc
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/components/exo/surface_delegate.h
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/components/exo/wayland/server.cc
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/85ad9323b2a3e7da8ca87ab0311d47660ba6bf8c/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d662f5ee16c2938cf5b24d75a073ea8eda9ccc7

commit 8d662f5ee16c2938cf5b24d75a073ea8eda9ccc7
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Apr 05 19:02:49 2018

[reland] Don't skip updating widget when resizing ClientControlledShellSurface

ClientControlledShellSurface doesn't use configure to resize.

This is reland of https://crrev.com/c/994173/5

TBR=reveman@chromium.org
BUG= 828586 
TEST=manual

Change-Id: Id39f3d0ac5b680aa74fef13df7d0631d5b9ca742
Reviewed-on: https://chromium-review.googlesource.com/998339
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548514}
[modify] https://crrev.com/8d662f5ee16c2938cf5b24d75a073ea8eda9ccc7/components/exo/shell_surface_base.cc

Status: Fixed (was: Started)

Sign in to add a comment