RasterDecoder requires sync_query capabilities for CPU raster |
||||||
Issue descriptionPrimary concern is that glFinish in RasterDecoder does not work as expected. Specifically, GLES2Decoder will fallback to glFinish for CPU raster if sync_query is not available. https://cs.chromium.org/chromium/src/cc/raster/staging_buffer_pool.cc?rcl=3e14280e15016fb08df07d14de2e82fea3ac5c8a&l=288 I tested with GLES2Decoder with a recompile and the fallback to glFinish works. However, the fallback to glFinish for RasterDecoder does not work. As noted in comment #3 below, this fallback is not required -- we should prefer sync_query. We can close this bug once we are confident that glFinish for RasterDecoder works as expected.
,
Apr 5 2018
,
Apr 10 2018
I'm not sure what this is asking exactly. While glFinish is functional, it forces synchronous completion of all commands, rather than the ones that are bracketed by the queries, and so is much less efficient.
,
Apr 10 2018
,
Apr 10 2018
Re commment #3: Updated the bug description. The issue here is that glFinish may not be working as expected. Agreed that we shouldn't use it for tile upload.
,
Apr 30 2018
Does this still happen after https://chromium-review.googlesource.com/1026839 ? Some code was assuming that both the compositor context and the worker context agreed on the sync_query capability, but that CL was cleaned it up.
,
May 14 2018
Woot! I can no longer produce with a build from today. Thanks for the clean up Dana. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by backer@chromium.org
, Apr 3 2018