New issue
Advanced search Search tips

Issue 828561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

XFA Caret blinks only while mouse is moving

Project Member Reported by hnakashima@chromium.org, Apr 3 2018

Issue description

On an XFA enabled build:

1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf
2. Click on the Name text field (or any other)
3. Leave the mouse still.
4. Move the mouse around the page.

Actual: Caret blinks ONLY while mouse is moving
Expected: Carel blinks as long as the text field is focused.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316

commit dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Apr 04 16:38:40 2018

Fix XFA caret blinking only while mouse moves.

Currently rect invalidations in XFA are only sent to the embedder
only when RunInvalidate() is executed.
For things which redraw on a timer, such as the caret, there was
no user event to call RunInvalidate() so the page would not redraw.
This CL changes the XFA code to send the invalidations to the
embedder immediately and expects the embedder to combine the
invalidations to limit overdraw.

Bug:  chromium:828561 
Change-Id: I298052fd7d0c373b029eec191cc6c74c63978348
Reviewed-on: https://pdfium-review.googlesource.com/29670
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_fflistbox.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_fffield.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffdocview.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffdocview.h
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffwidgethandler.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffwidget.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffcombobox.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_fwladapterwidgetmgr.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/parser/cxfa_node.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffwidget.h
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_fftextedit.cpp
[modify] https://crrev.com/dc566b0a76f9d2ad112c8cc35fa6dc8eaf942316/xfa/fxfa/cxfa_ffnotify.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330797ce54c871eb0b9232119a8ce876025c50df

commit 330797ce54c871eb0b9232119a8ce876025c50df
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 04 19:57:36 2018

Roll src/third_party/pdfium/ 28bb2f2ff..dc566b0a7 (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/28bb2f2ffe75..dc566b0a76f9

$ git log 28bb2f2ff..dc566b0a7 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 hnakashima Fix XFA caret blinking only while mouse moves.
2018-04-04 thestig Parse "yy" correctly for AFDate_FormatEx().
2018-04-04 dsinclair Decrease XML parser buffer size
2018-04-04 dsinclair [fwl] Restrict setting cursor outside text bounds

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:828561 , chromium:436572 , chromium:813195 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I2515beeac588ea2d53d3caa6d92bae0165da4824
Reviewed-on: https://chromium-review.googlesource.com/996232
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548171}
[modify] https://crrev.com/330797ce54c871eb0b9232119a8ce876025c50df/DEPS

Sign in to add a comment