WifiPollingPolicy not obeyed for initial wifi scan |
|||
Issue descriptionChrome should limit wifi scanning according to the WifiPollingPolicy, which typically restricts Chrome from scanning more than once every few minutes. However, the state used to enforce this policy is destroyed whenever the WifiDataProvider is stopped, which happens as soon as there are no active geolocation listeners. This allows callers to scan more frequently than allowed by ensuring the WifiDataProvider is recreated between each call.
,
Apr 5 2018
,
Jun 6 2018
This is still broken on ChromeOS, which uses an alternate implementation of the wifi_data_provider (wifi_data_provider_chromeos).
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99fa72cc64fc2bc7efea6f0887fa297c31e7efc6 commit 99fa72cc64fc2bc7efea6f0887fa297c31e7efc6 Author: Matt Reynolds <mattreynolds@chromium.org> Date: Thu Jun 07 15:23:52 2018 Retain wifi polling policy state on ChromeOS In a previous CL, WifiDataProvider implementations for other platforms were modified to retain the wifi polling policy state across restarts of the WifiDataProvider. This CL updates the Chrome OS implementation to also retain this information across provider restarts. Relevant commit: https://chromium.googlesource.com/chromium/src/+/abca656dd0f8e7aa02c21754ddb8581ab9e84b54 When the wifi polling policy state is lost, Chrome fails to correctly apply the initial polling delay the next time the WifiDataProvider is restarted. This can result in excessive use of WLAN hardware and the network geolocation service when the geolocation API is called many times in rapid succession. BUG=828547 Change-Id: Iecad5b7f12f2d8fc72196db9e2108a7d2286d7bd Reviewed-on: https://chromium-review.googlesource.com/1089190 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#565272} [modify] https://crrev.com/99fa72cc64fc2bc7efea6f0887fa297c31e7efc6/device/geolocation/wifi_data_provider_chromeos.cc [modify] https://crrev.com/99fa72cc64fc2bc7efea6f0887fa297c31e7efc6/device/geolocation/wifi_data_provider_chromeos.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 5 2018